This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
view: fix runDiagnostic output display #297
Merged
rohityadavcloud
merged 9 commits into
apache:master
from
shapeblue:fix-systemvm-router-run-diagnostic-293
Apr 29, 2020
Merged
view: fix runDiagnostic output display #297
rohityadavcloud
merged 9 commits into
apache:master
from
shapeblue:fix-systemvm-router-run-diagnostic-293
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
…-run-diagnostic-293
@shwstppr the output should also show stderr and exit value like old UI:
Side-note I'm getting network error, for some reason the API request fails that I couldn't debug - are you seeing this as well (when using a non-local mgmt server env): |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@rhtyd it works with a lab env and also with cloudmonkey local env |
…-run-diagnostic-293
…-run-diagnostic-293
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@shwstppr please follow the changes in future/related PRs |
@rhtyd I'll ask before making changes in future/related PRs |
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
) Fixes: #293 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #293