Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

view: fix runDiagnostic output display #297

Merged

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Apr 17, 2020

Fixes: #293

Screenshot from 2020-04-17 16-04-21

shwstppr and others added 2 commits April 17, 2020 16:07
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@rohityadavcloud
Copy link
Member

@shwstppr the output should also show stderr and exit value like old UI:

exitcode: 0

stderr:

stdout: PING 8.8.8.8 (8.8.8.8): 56 data bytes 64 bytes from 8.8.8.8: icmp_seq=0 ttl=50 time=7.575 ms 64 bytes from 8.8.8.8: icmp_seq=1 ttl=50 time=8.030 ms 64 bytes from 8.8.8.8: icmp_seq=2 ttl=50 time=14.950 ms 64 bytes from 8.8.8.8: icmp_seq=3 ttl=50 time=7.617 ms --- 8.8.8.8 ping statistics --- 4 packets transmitted, 4 packets received, 0% packet loss round-trip min/avg/max/stddev = 7.575/9.543/14.950/3.127 ms

Side-note I'm getting network error, for some reason the API request fails that I couldn't debug - are you seeing this as well (when using a non-local mgmt server env):
Screenshot from 2020-04-22 12-57-39

@shwstppr
Copy link
Contributor Author

@rhtyd it works with a lab env and also with cloudmonkey local env
Made changes to show stderr and errorCode,
Screenshot from 2020-04-22 15-36-06

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud rohityadavcloud merged commit 67848a5 into apache:master Apr 29, 2020
@rohityadavcloud rohityadavcloud deleted the fix-systemvm-router-run-diagnostic-293 branch April 29, 2020 21:02
@rohityadavcloud
Copy link
Member

@shwstppr please follow the changes in future/related PRs

@shwstppr
Copy link
Contributor Author

@rhtyd I'll ask before making changes in future/related PRs

weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
)

Fixes: #293

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Infrastructure > System VMs > Run Diagnostics does not show the command output
2 participants