vm: Simplifying Deploy VM Wizard #499
Conversation
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@PaulAngus Looks good ? |
davidjumani
force-pushed
the
simplify-deploy-vm
branch
from
6881110
to
b6c5add
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@davidjumani on the override root disk side can you remove the slider; so just the input and are we checking that size input is great than the size of template? |
davidjumani
force-pushed
the
simplify-deploy-vm
branch
from
b6c5add
to
d4b12dd
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
changed the title
|
Boot type, etc options are gone @davidjumani @utchoang can you review and test this as well? |
|
They aren't visible since we're using simulator. Tested it on a VMware setup @rhtyd |
|
David demo'd it to me @rhtyd, I thought that it did the job. I imagine there will be a lot of little tweaks we can make in future. but this iteration seemed a lot cleaner to me, so I gave it a thumbsup. |
|
Okay we're doing hypervisor specific fields now, will test and merge. |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
There was a problem hiding this comment.
LGTM tested manually.
@davidjumani please fixes the translation text.
@rhtyd Ready for review.
Thanks.
src/views/compute/DeployVM.vue
Outdated
| ></template-iso-selection> | ||
| @update-template-iso="updateFieldValue" /> | ||
| <span> | ||
| {{ $t('Override root disk size') }} |
There was a problem hiding this comment.
@davidjumani Can you fix translation/key label usage across views (see locales/en.json to pick the keys, all lowercase)
davidjumani
force-pushed
the
simplify-deploy-vm
branch
from
d4b12dd
to
90d8d63
Compare
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
Fixes #490
Fixes #491