-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves service offering resource #64
Improves service offering resource #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM didn't test it though; let's see how the github actions behave
@fabiomatavelli thank you for the PR. I liked how you've introduce a CI github action. There is a conflict with README, could you help resolve it. |
changes applied @rohityadavcloud, I think you'll need to approve it again |
Thanks @fabiomatavelli re-running github actions |
@fabiomatavelli can you help review/resolve the conflict? |
done @rohityadavcloud |
Co-authored-by: Vishesh <vishesh92@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Hi,
Here is some improvement in the
cloudstack_service_offering
resource so we can specify thecpu_number
,cpu_speed
andmemory
now.I've added the acceptance test CI which can be run with different versions of Cloudstack. Although it is failing, the specific test for this change is passing:
Also, I made a change in the README to include the updated version of the
cloudstack-simulator
.