Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource egress rule to accept protocol type ALL #8

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

harikrishna-patnala
Copy link
Contributor

This PR fixes #3

Previously only protocol types icmp, tcp, udp are supported, with this fix we have added support for protocol type ALL.

Tested by following steps

  1. Created a egress rule using below config and "terraform apply" created the new egress rule
    resource "cloudstack_egress_firewall" "default" {
    network_id = "2047d8a9-789d-41e6-8eba-a7fa597d0c92"
    rule {
    protocol = "ALL"
    }
  2. Removed the above config from configuration file and "terraform apply" deleted the above created rule

@rohityadavcloud
Copy link
Member

This needs testing, how was it tested @harikrishna-patnala (could be maybe integrate .travis.yml to do something?)

@harikrishna-patnala
Copy link
Contributor Author

I've tested this PR manually doing crud operations on resource egress firewall with both protocol types "ALL" and "icmp".

Yes adding .travis.yml for the basic testing for all other PRs is a good idea. I'll add it as a different PR.

@rohityadavcloud rohityadavcloud merged commit 216679d into main Oct 11, 2021
@rohityadavcloud rohityadavcloud added this to the v0.4.0 milestone Oct 11, 2021
Pearl1594 pushed a commit to Pearl1594/cloudstack-terraform-provider that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

* " " is not a valid protocol. Valid options are 'tcp', 'udp' and 'icmp'
2 participants