Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events not generating for BaseCmd classes #8771

Open
vishesh92 opened this issue Mar 11, 2024 · 1 comment
Open

Events not generating for BaseCmd classes #8771

vishesh92 opened this issue Mar 11, 2024 · 1 comment
Milestone

Comments

@vishesh92
Copy link
Member

ISSUE TYPE
  • Improvement Request
COMPONENT NAME

CLOUDSTACK VERSION
all
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

Events are not being generated for commands which extend BaseCmd. This results in missing events for some commands.

Ref.: #8630 (review)

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

@shwstppr
Copy link
Contributor

In my understanding, action events in ACS are created mainly by the @ActionEvent annotation. For BaseAsyncCmd we do publish events with Scheduled state but that is just it. Trying to publish events for BaseCmd may require a lot of changes and refactoring. Would it be better to fix the specific cases where events are not generated highlighted in #8630 (review)?
@vishesh92 @rohityadavcloud @sureshanaparti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discuss
Status: Todo
Development

No branches or pull requests

3 participants