New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Fixes: allow filtering on alertype in UI & add events tab #8630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8630 +/- ##
============================================
+ Coverage 29.99% 30.90% +0.91%
- Complexity 33085 34278 +1193
============================================
Files 5346 5356 +10
Lines 375445 376186 +741
Branches 54605 54700 +95
============================================
+ Hits 112622 116278 +3656
+ Misses 247938 244611 -3327
- Partials 14885 15297 +412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
@blueorangutan package |
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8609 |
@vishesh92 can you fix the packaging job failures. Should this pointed to main branch or 4.19 ? There is a linstor related exception
|
@kiranchavala there was an issue with main which is fixed now. @blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8611 |
[SF] Trillian test result (tid-9166)
|
@blueorangutan test alma9 kvm-alma9 |
@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
[SF] Trillian test result (tid-9183)
|
@blueorangutan test alma9 kvm-alma9 keepEnv |
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
[SF] Trillian test result (tid-9193)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm and tested in lab env (monkey style)
@kiranchavala do you want to test this? |
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but this needs testing before merging the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find the following issues
On Issue #8063
The project roles releated events are not logged in
steps to reproduce the issue
- Create a project role and try to find the related event in events tab of project
CMK> list eventtypes filter=name | grep PROJECT
"name": "PROJECT.ROLE.CREATE"
"name": "PROJECT.ROLE.UPDATE"
"name": "PROJECT.ROLE.DELETE"
"name": "PROJECT.ROLE.PERMISSION.CREATE"
"name": "PROJECT.ROLE.PERMISSION.UPDATE"
"name": "PROJECT.ROLE.PERMISSION.DELETE"
- Host related events are not shown as completed
Infrastructure > Hosts
- Internal LB events are not populated
Network > VPC > Networks > Tier > Internal LB VM > Click on a particular Internal LB > Events
Also the events struck in the scheduled state
list eventtypes filter=name | grep INTERNAL
"name": "INTERNALLBVM.START"
"name": "INTERNALLBVM.STOP"
Also it would to nice to include INTERNALLBM .CREATE, INTERNALLBVM.DESTROY
On Issue #7251
- SSH KEY PAIR events are not present
- Affinity groups
The Affinity events are not shown as completed
- Vm snapshot related events are not shown
Storage > VMSnapshots
- The firewall, portforwarding and Loadbalancing events on a public Ip are not shown
Network > Public Ip Address
PORTABLE.IPASSIGN
PORTABLE.IPRELEASE
NET.RULEADD
NET.RULEDELETE
NET.RULEMODIFY
FIREWALL.OPEN
FIREWALL.CLOSE
LB.ASSIGN.TO.RULE
LB.REMOVE.FROM.RULE
LB.CREATE
LB.DELETE
LB.STICKINESSPOLICY.CREATE
LB.STICKINESSPOLICY.DELETE
LB.HEALTHCHECKPOLICY.CREATE
LB.HEALTHCHECKPOLICY.DELETE
LB.UPDATE
- When you apply static nat on public ip, the events tab gets dissaperaed
Create a netowrk
STATICNAT.ENABLE
STATICNAT.DISABLE
- VPN users
No event tab present
Network > vpn users
VPN.USER.ADD
VPN.USER.REMOVE
@kiranchavala Events not showing up would be a different issue and not related to the UI. I have fixed the issue where enabling static nat for a public IP was resulting in Events tab disappearing. |
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@kiranchavala I have created a new issue to fix the missing events #8771 |
@kiranchavala , I am merging this as all original issues have been addressed and the new issue has been created. |
Description
This PR fixes #8063
Fixes #7251
Fixes #8522
Fixes #7193
This also adds a new command
listAlertTypes
to list all alert types to be used in filtering for listing alerts in UI.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?