Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fixes: allow filtering on alertype in UI & add events tab #8630

Merged
merged 6 commits into from Apr 4, 2024

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Feb 8, 2024

Description

This PR fixes #8063
Fixes #7251
Fixes #8522
Fixes #7193
This also adds a new command listAlertTypes to list all alert types to be used in filtering for listing alerts in UI.
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 30.90%. Comparing base (a924a11) to head (9967e27).
Report is 41 commits behind head on 4.19.

Files Patch % Lines
ui/src/components/view/SearchView.vue 0.00% 21 Missing ⚠️
ui/src/config/section/offering.js 0.00% 17 Missing ⚠️
.../api/command/admin/resource/ListAlertTypesCmd.java 0.00% 14 Missing ⚠️
...che/cloudstack/api/response/AlertTypeResponse.java 0.00% 11 Missing ⚠️
ui/src/config/section/compute.js 0.00% 5 Missing ⚠️
ui/src/config/section/network.js 0.00% 4 Missing ⚠️
ui/src/views/network/PublicIpResource.vue 0.00% 4 Missing ⚠️
ui/src/config/section/infra/ilbvms.js 0.00% 3 Missing ⚠️
...ommand/admin/acl/project/DeleteProjectRoleCmd.java 0.00% 2 Missing ⚠️
...in/acl/project/DeleteProjectRolePermissionCmd.java 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8630      +/-   ##
============================================
+ Coverage     29.99%   30.90%   +0.91%     
- Complexity    33085    34278    +1193     
============================================
  Files          5346     5356      +10     
  Lines        375445   376186     +741     
  Branches      54605    54700      +95     
============================================
+ Hits         112622   116278    +3656     
+ Misses       247938   244611    -3327     
- Partials      14885    15297     +412     
Flag Coverage Δ
simulator-marvin-tests 24.73% <40.35%> (+1.17%) ⬆️
uitests 4.38% <0.00%> (-0.01%) ⬇️
unit-tests 16.58% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 changed the title Add alertTypes & allow filtering on alertype in UI UI Fixes: allow filtering on alertype in UI & add events tab Feb 8, 2024
@vishesh92 vishesh92 marked this pull request as ready for review February 8, 2024 19:47
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@kiranchavala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8609

@kiranchavala
Copy link
Contributor

@vishesh92 can you fix the packaging job failures.

Should this pointed to main branch or 4.19 ?

There is a linstor related exception

15:24:12 [INFO] ------------------------------------------------------------------------
15:24:12 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-storage-volume-linstor: Compilation failure
15:24:12 [ERROR] /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.20.0.0-SNAPSHOT/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:[289,12] error: cannot find symbol
15:24:12 [ERROR]   symbol:   variable s_logger
15:24:12 [ERROR]   location: class LinstorStorageAdaptor
15:24:12 [ERROR] 
15:24:12 [ERROR] -> [Help 1]
15:24:12 [ERROR] 
15:24:12 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
15:24:12 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
15:24:12 [ERROR] 
15:24:12 [ERROR] For more information about the errors and possible solutions, please read the following articles:
15:24:12 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
15:24:12 [ERROR] 
15:24:12 [ERROR] After correcting the problems, you can resume the build with the command
15:24:12 [ERROR]   mvn <args> -rf :cloud-plugin-storage-volume-linstor
15:24:12 error: Bad exit status from /var/tmp/rpm-tmp.TSR0y4 (%build)
15:24:12 

@vishesh92
Copy link
Member Author

@vishesh92 can you fix the packaging job failures.

@kiranchavala there was an issue with main which is fixed now.

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8611

@vishesh92 vishesh92 changed the base branch from main to 4.19 February 11, 2024 07:36
@vishesh92 vishesh92 changed the base branch from 4.19 to main February 11, 2024 07:37
@blueorangutan
Copy link

[SF] Trillian test result (tid-9166)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 1651 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8630-t9166-kvm-alma9.zip
Smoke tests completed. 7 look OK, 122 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
runTest Error 0.00 test_2fa.py
runTest Error 0.00 test_diagnostics.py
runTest Error 0.00 test_accounts.py
runTest Error 0.00 test_deploy_vm_extra_config_data.py
runTest Error 0.00 test_affinity_groups_projects.py
runTest Error 0.00 test_deploy_vms_with_varied_deploymentplanners.py
runTest Error 0.00 test_affinity_groups.py
runTest Error 0.00 test_annotations.py
runTest Error 0.00 test_domain_disk_offerings.py
runTest Error 0.00 test_async_job.py
runTest Error 0.00 test_attach_multiple_volumes.py
runTest Error 0.00 test_direct_download.py
runTest Error 0.00 test_backup_recovery_dummy.py
runTest Error 0.00 test_events_resource.py
runTest Error 0.00 test_backup_recovery_veeam.py
runTest Error 0.00 test_deploy_vm_iso.py
runTest Error 0.00 test_certauthority_root.py
runTest Error 0.00 test_disk_provisioning_types.py
runTest Error 0.00 test_cluster_drs.py
runTest Error 0.00 test_global_acls.py
runTest Error 0.00 test_console_endpoint.py
runTest Error 0.00 test_deploy_vm_with_userdata.py
runTest Error 0.00 test_create_list_domain_account_project.py
runTest Error 0.00 test_global_settings.py
runTest Error 0.00 test_create_network.py
runTest Error 0.00 test_deploy_vgpu_enabled_vm.py
runTest Error 0.00 test_disk_offerings.py
runTest Error 0.00 test_guest_os.py
runTest Error 0.00 test_deploy_virtio_scsi_vm.py
runTest Error 0.00 test_deploy_vm_iso_uefi.py
runTest Error 0.00 test_guest_vlan_range.py
runTest Error 0.00 test_deploy_vm_root_resize.py
runTest Error 0.00 test_deploy_vms_in_parallel.py
runTest Error 0.00 test_domain_network_offerings.py
runTest Error 0.00 test_domain_service_offerings.py
runTest Error 0.00 test_domain_vpc_offerings.py
runTest Error 0.00 test_enable_account_settings_for_domain.py
runTest Error 0.00 test_gateway_on_shared_networks.py
runTest Error 0.00 test_host_control_state.py
runTest Error 0.00 test_hostha_simulator.py
runTest Error 0.00 test_host_ping.py
runTest Error 0.00 test_image_store_object_migration.py
runTest Error 0.00 test_internal_lb.py
runTest Error 0.00 test_ipv6_infra.py
runTest Error 0.00 test_iso.py
runTest Error 0.00 test_kubernetes_clusters.py
runTest Error 0.00 test_kubernetes_supported_versions.py
runTest Error 0.00 test_list_accounts.py
runTest Error 0.00 test_list_disk_offerings.py
runTest Error 0.00 test_over_provisioning.py
runTest Error 0.00 test_list_domains.py
runTest Error 0.00 test_list_hosts.py
runTest Error 0.00 test_nonstrict_affinity_group.py
runTest Error 0.00 test_list_ids_parameter.py
runTest Error 0.00 test_list_service_offerings.py
runTest Error 0.00 test_list_storage_pools.py
runTest Error 0.00 test_list_volumes.py
runTest Error 0.00 test_password_server.py
runTest Error 0.00 test_loadbalance.py
runTest Error 0.00 test_login.py
runTest Error 0.00 test_metrics_api.py
runTest Error 0.00 test_migration.py
runTest Error 0.00 test_multipleips_per_nic.py
runTest Error 0.00 test_nested_virtualization.py
runTest Error 0.00 test_network_acl.py
runTest Error 0.00 test_portable_publicip.py
runTest Error 0.00 test_network_ipv6.py
runTest Error 0.00 test_outofbandmanagement.py
runTest Error 0.00 test_network_permissions.py
runTest Error 0.00 test_network.py
runTest Error 0.00 test_nic_adapter_type.py
runTest Error 0.00 test_nic.py
runTest Error 0.00 test_non_contigiousvlan.py
runTest Error 0.00 test_outofbandmanagement_nestedplugin.py
runTest Error 0.00 test_persistent_network.py
runTest Error 0.00 test_portforwardingrules.py
runTest Error 0.00 test_primary_storage.py
runTest Error 0.00 test_privategw_acl_ovs_gre.py
runTest Error 0.00 test_privategw_acl.py
runTest Error 0.00 test_projects.py
runTest Error 0.00 test_public_ip_range.py
runTest Error 0.00 test_pvlan.py
runTest Error 0.00 test_quarantined_ips.py
runTest Error 0.00 test_regions.py
runTest Error 0.00 test_register_userdata.py
runTest Error 0.00 test_volumes.py
runTest Error 0.00 test_reset_configuration_settings.py
runTest Error 0.00 test_reset_vm_on_reboot.py
runTest Error 0.00 test_vm_life_cycle.py
runTest Error 0.00 test_resource_accounting.py
runTest Error 0.00 test_resource_detail.py
runTest Error 0.00 test_vm_schedule.py
runTest Error 0.00 test_router_dhcphosts.py
runTest Error 0.00 test_router_dns.py
runTest Error 0.00 test_router_dnsservice.py
runTest Error 0.00 test_vm_deployment_planner.py
runTest Error 0.00 test_routers_iptables_default_policy.py
runTest Error 0.00 test_routers_network_ops.py
runTest Error 0.00 test_routers.py
runTest Error 0.00 test_vm_snapshot_kvm.py
runTest Error 0.00 test_safe_shutdown.py
runTest Error 0.00 test_scale_vm.py
runTest Error 0.00 test_secondary_storage.py
runTest Error 0.00 test_service_offerings.py
runTest Error 0.00 test_vm_snapshots.py
runTest Error 0.00 test_set_sourcenat.py
runTest Error 0.00 test_vpc_ipv6.py
runTest Error 0.00 test_snapshots.py
runTest Error 0.00 test_ssvm.py
runTest Error 0.00 test_storage_policy.py
runTest Error 0.00 test_templates.py
runTest Error 0.00 test_update_security_group.py
runTest Error 0.00 test_usage_events.py
runTest Error 0.00 test_usage.py
runTest Error 0.00 test_vnf_templates.py
runTest Error 0.00 test_vm_autoscaling.py
runTest Error 0.00 test_vm_lifecycle_unmanage_import.py
runTest Error 0.00 test_vpc_redundant.py
runTest Error 0.00 test_vpc_router_nics.py
runTest Error 0.00 test_vpc_vpn.py
runTest Error 0.00 test_host_maintenance.py
runTest Error 0.00 test_hostha_kvm.py

@vishesh92
Copy link
Member Author

@blueorangutan test alma9 kvm-alma9

@blueorangutan
Copy link

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9183)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 48789 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8630-t9183-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

@blueorangutan test alma9 kvm-alma9 keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9193)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 49647 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8630-t9193-kvm-alma9.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 341.39 test_safe_shutdown.py

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and tested in lab env (monkey style)

@DaanHoogland
Copy link
Contributor

@kiranchavala do you want to test this?

@rohityadavcloud
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8630 (QA-JID-282)

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but this needs testing before merging the PR

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92

Please find the following issues

On Issue #8063

The project roles releated events are not logged in

steps to reproduce the issue

  1. Create a project role and try to find the related event in events tab of project

CMK> list eventtypes filter=name | grep PROJECT
"name": "PROJECT.ROLE.CREATE"
"name": "PROJECT.ROLE.UPDATE"
"name": "PROJECT.ROLE.DELETE"
"name": "PROJECT.ROLE.PERMISSION.CREATE"
"name": "PROJECT.ROLE.PERMISSION.UPDATE"
"name": "PROJECT.ROLE.PERMISSION.DELETE"

project role related events

  1. Host related events are not shown as completed

Infrastructure > Hosts

host

  1. Internal LB events are not populated

Network > VPC > Networks > Tier > Internal LB VM > Click on a particular Internal LB > Events

Also the events struck in the scheduled state

list eventtypes filter=name | grep INTERNAL
"name": "INTERNALLBVM.START"
"name": "INTERNALLBVM.STOP"

Also it would to nice to include INTERNALLBM .CREATE, INTERNALLBVM.DESTROY

Internal LB events

Internal LB events2

Internal LB events3

On Issue #7251

  1. SSH KEY PAIR events are not present

REGISTER.SSH.KEYPAIR
ssh key pair events

  1. Affinity groups

The Affinity events are not shown as completed

Affinity groups events
  1. Vm snapshot related events are not shown

Storage > VMSnapshots

vmsnapshot event
  1. The firewall, portforwarding and Loadbalancing events on a public Ip are not shown

Network > Public Ip Address

PORTABLE.IPASSIGN
PORTABLE.IPRELEASE
NET.RULEADD
NET.RULEDELETE
NET.RULEMODIFY

FIREWALL.OPEN
FIREWALL.CLOSE
LB.ASSIGN.TO.RULE
LB.REMOVE.FROM.RULE
LB.CREATE
LB.DELETE
LB.STICKINESSPOLICY.CREATE
LB.STICKINESSPOLICY.DELETE
LB.HEALTHCHECKPOLICY.CREATE
LB.HEALTHCHECKPOLICY.DELETE
LB.UPDATE
public ip events

  1. When you apply static nat on public ip, the events tab gets dissaperaed

Create a netowrk

STATICNAT.ENABLE
STATICNAT.DISABLE

staticnat-publicip
  1. VPN users

No event tab present
Network > vpn users

VPN.USER.ADD
VPN.USER.REMOVE

vpn user events

@vishesh92
Copy link
Member Author

@kiranchavala Events not showing up would be a different issue and not related to the UI.
For VPN users events, we are currently not linking them with any resource and they don't have a resource type either.

I have fixed the issue where enabling static nat for a public IP was resulting in Events tab disappearing.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8630 (QA-JID-294)

@vishesh92
Copy link
Member Author

@kiranchavala I have created a new issue to fix the missing events #8771

@DaanHoogland
Copy link
Contributor

@kiranchavala , I am merging this as all original issues have been addressed and the new issue has been created.

@DaanHoogland DaanHoogland merged commit c25264b into apache:4.19 Apr 4, 2024
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the ui-fixes branch April 4, 2024 11:52
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment