Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

ProjectMoon · 2016-01-12T10:36:24Z

This is a follow-up fix for pull request #1162, which added a --no-start option to cloudstack-setup-management. It is necessary for further script execution under systemd, otherwise the service aborts.

DaanHoogland · 2016-01-12T11:29:09Z

python/lib/cloudutils/serviceConfigServer.py

        if self.syscfg.env.noStart == False:
+            self.syscfg.svo.stopService("cloudstack-management")


so if nostart is false (start is true ??) the service is stopped. Am I understanding this wrong? it seems like we don't want this here and not unconditionally either but only if nostart is true.

This is the original behavior of the script, before --no-start was added. When --no-start is NOT specified, the script tries to make sure that the service is stopped before starting it again.

davidamorimcruz · 2016-01-12T12:34:05Z

LGTM, this change fixes the logic regarding the expected state of the service prior to running the script.

DaanHoogland · 2016-01-13T08:46:19Z

complaining about a license, false positive: server/test/com/cloud/event/ActionEventUtilsTest.java

DaanHoogland · 2016-01-13T10:39:13Z

LGTM, pinging @remibergsma

remibergsma · 2016-01-13T10:46:27Z

2xLGTM, no test results. Did anyone verify this works?

DaanHoogland · 2016-01-13T12:55:36Z

@remibergsma @ProjectMoon did himself, as I read it. This is a systemd installation script it won't be touched by the integration tests. You are not satisfied with this?

remibergsma · 2016-01-13T13:20:32Z

@DaanHoogland This is not systemd, this is a python script to configure management. Why don't we build an environment and try this script with its parameters. Even if there's no integration test, we should still test/verify the changes IMHO.

DaanHoogland · 2016-01-13T13:23:22Z

I know, I said 'systemd install script'. I am not taking the time to test this now. I can ask @davidamorimfaria . David?

ProjectMoon · 2016-01-22T10:13:27Z

Perhaps I can make a small example test that starts cloudstack-setup-management under systemd with both --no-start and without it, showing the difference in behavior (i.e. working vs deadlock)?

rohityadavcloud · 2016-01-27T15:31:54Z

LGTM, let's merge after some tests

It will only run the stop command when --no-start is specified.

ProjectMoon · 2016-02-18T10:36:51Z

PR updated to latest 4.6.

ProjectMoon · 2016-02-18T11:23:00Z

Also, forgot I was making a test case for this. Will update my agenda to get this done.

bvbharatk · 2016-03-25T11:17:02Z

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

ACS CI BVT Run

Sumarry:
Build Number 127
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=2
Skipped=4

Failed tests:

integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
- test_dedicateGuestVlanRange Failing since 2 runs
integration.smoke.test_volumes.TestCreateVolume
- test_06_download_detached_volume Failing since 2 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

Passed test suits:
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering

kiwiflyer · 2016-04-29T20:28:25Z

Team,

Where are we currently on this PR?

ProjectMoon · 2016-04-30T17:17:55Z

Right now I suppose I still need to make a unit test. And I guess also re-open against 4.7.

rohityadavcloud · 2016-05-02T12:14:49Z

@ProjectMoon thanks, please open against master; unlikely we'll do 4.7.x 4.8.x releases

swill · 2016-05-02T17:22:58Z

We are still accepting bug fixes in 4.7 and 4.8, but all features should be added to master. Anything merged into 4.7 or 4.8 will be forward merged up through master. I agree, this probably should be opened against master.

ProjectMoon · 2016-05-26T11:31:08Z

Closing to open against master.

[CLOUDSTACK-9645] Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management.New version against #1330, opened against master. ``` Moving stop of management in config inside if statement. It will only run the stop command when --no-start is specified. ``` * pr/1566: CLOUDSTACK-9645: Moving stop of management in config inside if statement. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

DaanHoogland reviewed Jan 12, 2016
View reviewed changes

Moving stop of management in config inside if statement.

38182ec

It will only run the stop command when --no-start is specified.

ProjectMoon closed this May 26, 2016

ProjectMoon deleted the pr-fix-mgmt-setup branch May 26, 2016 11:31

ProjectMoon mentioned this pull request May 26, 2016

[CLOUDSTACK-9645] Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1566

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

ProjectMoon commented Jan 12, 2016

DaanHoogland Jan 12, 2016

ProjectMoon Jan 12, 2016

davidamorimcruz commented Jan 12, 2016

DaanHoogland commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

remibergsma commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

remibergsma commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

ProjectMoon commented Jan 22, 2016

rohityadavcloud commented Jan 27, 2016

ProjectMoon commented Feb 18, 2016

ProjectMoon commented Feb 18, 2016

bvbharatk commented Mar 25, 2016

kiwiflyer commented Apr 29, 2016

ProjectMoon commented Apr 30, 2016

rohityadavcloud commented May 2, 2016

swill commented May 2, 2016

ProjectMoon commented May 26, 2016

		if self.syscfg.env.noStart == False:
		self.syscfg.svo.stopService("cloudstack-management")

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

Followup fix for #1162: Add support for not (re)starting server after cloud-setup-management. #1330

Conversation

ProjectMoon commented Jan 12, 2016

DaanHoogland Jan 12, 2016

Choose a reason for hiding this comment

ProjectMoon Jan 12, 2016

Choose a reason for hiding this comment

davidamorimcruz commented Jan 12, 2016

DaanHoogland commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

remibergsma commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

remibergsma commented Jan 13, 2016

DaanHoogland commented Jan 13, 2016

ProjectMoon commented Jan 22, 2016

rohityadavcloud commented Jan 27, 2016

ProjectMoon commented Feb 18, 2016

ProjectMoon commented Feb 18, 2016

bvbharatk commented Mar 25, 2016

ACS CI BVT Run

kiwiflyer commented Apr 29, 2016

ProjectMoon commented Apr 30, 2016

rohityadavcloud commented May 2, 2016

swill commented May 2, 2016

ProjectMoon commented May 26, 2016