verifying template creation permission based on global parameter #153
Conversation
|
@gauravaradhye is this something you could take a look at? |
|
@terbolous yes I will review this. |
| @classmethod | ||
| def updateConfigurAndRestart(cls,name, value): | ||
| Configurations.update(cls.api_client, | ||
| name,value ) |
There was a problem hiding this comment.
Fix pep8 issues. You can do this using autopep8 tool.
pip install autopep8.
autopep8 -i -a -a fileName.py
Then check for any issues remaining to be fixed using pep8 fileName.py command. If there are any, fix them manually.
Autopep8 will fix most of the issues but not all.
|
@gauravaradhye is it to be merged, is extra work necessary? |
|
@shwetaag are you still working on this? (if not can you close it?) |
|
@DaanHoogland Let's wait for @shwetaag to respond. The patch is not yet updated after the review comments. |
|
@gauravaradhye and @DaanHoogland another request for this was created #184 |
Create volume form with support for custom disk offerings. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
Test to create Public Template by registering or by snapshot and volume when
Global parameter 'allow.public.user.template' is set to False
@steps:
1.Set Global parameter 'allow.public.user.template' as False. Restart Management server
2. Create a domain
3. Create a domain admin and a domain user
4. Create a vm as domain user
5. take snapshot of root disk as user vm
6. try to create public template from snapshot . It should fail
7. stop the VM
8. take the public template from volume. it should fail
9. register a public template as a domain user . it should fail
10. create a VM as domain admin
11. create a snapshot of root disk as domain admin
12 create a public template of the snapshot .it should fail
13. Register a public template as domain admin. it should fail
14 Stop the vm as domain admin
15. Create a template from volume as domain admin . it should fail