[CLOUDSTACK-9643] Now returning os info with the list snapshot response #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjectMoon
changed the title
|
Rebased to latest master. |
|
@blueorangutan package |
|
@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1618 |
| @@ -157,6 +156,7 @@ | |||
| import org.apache.cloudstack.usage.Usage; | |||
| import org.apache.cloudstack.usage.UsageService; | |||
| import org.apache.cloudstack.usage.UsageTypes; | |||
| import org.apache.commons.collections.CollectionUtils; | |||
There was a problem hiding this comment.
Why was this import added? I don't see it used anywhere in the patch.
There was a problem hiding this comment.
It is used in ApiResponseHelper.
|
Please add/modify Marvin tests based on these scenarios. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-205 |
|
Rebased to latest master. The comments will also be addressed soon, hopefully. |
|
Code review issues have been addressed, with the exception of combining the Guest OS ID/VM Instance ID into a join method on VolumeDao. There was some compilation failure in the F5 plugin when I tried building locally. Will see if that happens here too. |
|
@ProjectMoon thanks, can you add a JIRA id for this and also use that in your commit's PR. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232 |
|
Updated to latest master, and now with a JIRA ticket. |
ProjectMoon
changed the title
|
Thanks @ProjectMoon |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-305 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-550)
|
|
LGTM, the failure in Travis is caused by env issue and not the PR itself. Merging this based on review, and test results. |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
[CLOUDSTACK-9643] Now returning os info with the list snapshot responseThis commit adds the ID and display name of the OS on the volume. * pr/1618: CLOUDSTACK-9643: Now returning os info with the list snapshot response Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ID and display name of the OS on the volume.