[CLOUDSTACK-9644] Adding missing bits field to TemplateResponse #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
RPM packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-1622. |
|
@rhtyd Travis appears to have failed due to a missing file. Could you please investigate? |
|
@ProjectMoon is there a JIRA associated with this change? Also, could you please update the |
|
@ProjectMoon can you push -f or close+open this PR to re-kick Travis? |
|
Will check the smoke tests for Marvin. |
|
Packaging result: ✔centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1622 |
|
@ProjectMoon Travis is now passing, but Jenkins failed. Could you please investigate the failure and fix it? Also, updating the |
|
Will check it out on Monday. Very weird that the end of the build is not an error specifically. Just "ending due to build failure" or some such. The first exception I see is: Is that relevant? |
|
Packaging result: ✔centos6 ✔centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1622 |
|
@blueorangutan kick |
|
A Trillian-Jenkins job has been kicked to build packages and start testing. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1622 |
|
Rebased to latest master, though I still haven't checked into the Jenkins issue. |
|
@ProjectMoon the URI exception is caused by a attempting to parse an unrecognized/unregistered scheme (lswitch). It would be a problem at runtime for the management server, and need to be addressed. |
| @@ -169,6 +169,10 @@ | |||
| @Param(description = "additional key/value details tied with template") | |||
| private Map details; | |||
|
|
|||
| @SerializedName(ApiConstants.BITS) | |||
| @Param(description="the processor bit size") | |||
There was a problem hiding this comment.
Please add "since" in Param
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-76 |
|
This has been rebased to the latest master, and the code review suggestions applied. |
|
Build failed due to running out of disk space. Will re-trigger. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-206 |
|
Rebased to latest master. |
|
Thanks @ProjectMoon |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@ProjectMoon can you add a JIRA id for this, also in the commit's summary |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-230 |
ProjectMoon
changed the title
|
Updated to latest master, and a JIRA ticket has been created. |
|
Thanks @ProjectMoon |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-303 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-545)
|
|
@ProjectMoon is there any possible ui change for this? if yes, I suggest to commit it together with this PR. |
|
LGTM, Travis/Jenkins failure is not caused by this. Validated build, and Trillian tests. Merging this now. |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
[CLOUDSTACK-9644] Adding missing bits field to TemplateResponseThis pull request adds a bits field for template size, and sets it equal to ISO size. * pr/1622: CLOUDSTACK-9644: Adding missing bits field to TemplateResponse Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a bits field for template size, and sets it equal to ISO size.