-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix Dockerfile #1769
tools: fix Dockerfile #1769
Conversation
LGTM. @pdion891 would you like to review? |
Could you look if it conflict with #1435 ? Because I made a pull request to automatically increment version in docker file when changing release of master via |
Changes look good to me, but waiting for @pdion891 to tell us more :) |
ok, I'll update the PR and merge it I think the PR go all required LGTM. I'll confirmed with John, in case he is in a code freeze period. |
Hi @resmo, I've made some changes on the Docker file so it might not be possible to merge this PR in the current state. Thanks! |
ok, np closing for now |
Build a docker image did not work anymore for various reasons. This is how I fixed it