CLOUDSTACK-9724: Fixed missing additional public ip on tier network w… #1885
Conversation
| @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean postApplyRules, List<Pub | |||
| } | |||
| } else { | |||
| if (activeCount != null && activeCount > 0) { | |||
| if (network.getVpcId() != null) { | |||
There was a problem hiding this comment.
@jayapalu Please improve the code comment
There was a problem hiding this comment.
Improved. Added more details and rebased on master
|
Code changes LGTM |
|
The issue can be reproduced and fixed by this PR. |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 Failed tests:
Skipped tests: Passed test suits: |
|
Failed test cases are not related to this PR code changes |
|
tag:mergeready |
CLOUDSTACK-9724: Fixed missing additional public ip on tier network wIn VPC tier network acquire an ip and configure the PF service on it. VR now will have the two ip addresses on the interface. Now restart the VPC tier network with cleanup option. After router comes up the public interface has only one ip (source nat ip) Fixed the above issue. * pr/1885: CLOUDSTACK-9724: Fixed missing additional public ip on tier network with cleanup Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
In VPC tier network acquire an ip and configure the PF service on it. VR now will have the two ip addresses on the interface.
Now restart the VPC tier network with cleanup option. After router comes up the public interface has only one ip (source nat ip)
Fixed the above issue.