ipv6: Set IPv6 CIDR and Gateway in 'nic' profile #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this information a NPE might be triggered when starting a VR, SSVM or CP as this information is read from the 'nics' table and causes a NPE. During deployment we should set the IPv6 Gateway and CIDR for the NIC object so that it is persisted to the database. Signed-off-by: Wido den Hollander <wido@widodh.nl>
|
This regression was introduced with PR #1700, so my bad. Found this myself during tests. Assume nobody is using it yet as it has only been there in master. |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-472 |
|
@blueorangutan test centos7 vmware-60u2 |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests |
|
Trillian test result (tid-803)
|
|
LGTM, let's merge this blocker @karuturi |
|
@rhtyd, Can @blueorangutan run basic network tests? |
|
also, as @wido said, this happens only when ipv6 is set. So, its not a blocker. I will wait and see if someone can run basic network BVT. |
|
@karuturi blueorangutan by default can run all the smoke/component tests -- but by default only in an advanced zone (advanced network). If your question was around testing this in basic zone (shared network), I'll need to discuss with my team and get back to you. |
|
yes, my question was about testing this PR in basic zone. Thanks. |
|
merging this. |
asfgit
pushed a commit
that referenced
this pull request
Feb 27, 2017
ipv6: Set IPv6 CIDR and Gateway in 'nic' profileWithout this information a NPE might be triggered when starting a VR, SSVM or CP as this information is read from the 'nics' table and causes a NPE. During deployment we should set the IPv6 Gateway and CIDR for the NIC object so that it is persisted to the database. Signed-off-by: Wido den Hollander <wido@widodh.nl> * pr/1927: ipv6: Set IPv6 CIDR and Gateway in 'nic' profile Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this information a NPE might be triggered when starting a VR, SSVM or CP
as this information is read from the 'nics' table and causes a NPE.
During deployment we should set the IPv6 Gateway and CIDR for the NIC object so that
it is persisted to the database.
Signed-off-by: Wido den Hollander wido@widodh.nl