Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9638 Problems caused when inputting double-byte numbers fo… #1967

Merged
merged 1 commit into from May 25, 2017

Conversation

bvbharatk
Copy link
Contributor

…r custom compute offerings

@koushik-das
Copy link
Contributor

Code change LGTM

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review

@bvbharatk
Copy link
Contributor Author

Ready to merge.

@karuturi
Copy link
Member

@bvbharat can you start internal CI and post results?

@Nikhil-99
Copy link

Nikhil-99 commented Apr 24, 2017

Desired functionality is working fine..
Custom compute offering using double byte values
screenshot 36

Output: Successful creation and listing of instances
screenshot 38

Test results are as desired. LGTM

@cloudmonger
Copy link

ACS CI BVT Run

Sumarry:
Build Number 621
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_network.py

  • test_public_ip_admin_account Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

@bvbharatk
Copy link
Contributor Author

the failed test is not related to this PR changes.

@bvbharatk
Copy link
Contributor Author

@kiwiflyer
This PR has two LGTMS and a test run. Can you please tag this merge ready. I am not a committer and so i cannot do the needful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants