Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9666 Added basic configuration validation for the config d… #1968

Merged
merged 1 commit into from May 17, 2017

Conversation

bvbharatk
Copy link
Contributor

…rive global settings

@koushik-das
Copy link
Contributor

Code changes LGTM

@cloudmonger
Copy link

ACS CI BVT Run

Sumarry:
Build Number 462
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_non_contigiousvlan.py

  • test_extendPhysicalNetworkVlan Failed

  • test_routers_network_ops.py

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

  • test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@Nikhil-99
Copy link

Previously, the global config parameters "externaldhcp.vmip.retrieval.interval" , "externaldhcp.vmip.max.retry" and "externaldhcp.vmipFetch.threadPool.max" have no validation (allowing negative numbers and zero).
After validation
Output:
screenshot 92
screenshot 94
screenshot 97

Test results are as desired. LGTM

@karuturi karuturi added this to the 4.10.0.0 milestone May 17, 2017
@karuturi karuturi merged commit 5c316a9 into apache:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants