Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for vpcrouter #1973

Closed
wants to merge 3 commits into from

Conversation

dmabry
Copy link
Contributor

@dmabry dmabry commented Feb 27, 2017

[BACKPORT PR1954]

moved logrotate from cron.daily to cron.hourly for vpcrouter in cloud-early-config. This brings 'vpcrouter' inline with 'router'. We are having issues with cloud.log not rotating fast enough, which filled up /var/log and ultimately caused the VR to stop functioning in such a way that it prevented new VMs from being deployed.

@dmabry
Copy link
Contributor Author

dmabry commented Feb 27, 2017

Did a git cherry-pick as suggested by @rafaelweingartner.

@rafaelweingartner
Copy link
Member

@dmabry as I posted on the other PR, I only suggested git cherry-pick because I thought it would preserve the commit hash. It was a misunderstanding from me. The git hash is generated based on parent commit as well as other bits of information. Therefore, even when using git cherry-pick the hash of commits between branches will always be different (unless a hash collision happens).

The git cherry-pick is quite useful when you have to apply a bunch of changes, but in your case, I do not think you need it. The way you did before was ok.

BTW: I think a single commit to introduce these changes is enough ;)

@dmabry
Copy link
Contributor Author

dmabry commented Mar 3, 2017

Closing PR as it will be cherry-picked from master.

@dmabry dmabry closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants