New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places #2123
CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places #2123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a9bd065
to
8fd3920
Compare
LGTM |
8fd3920
to
bb2cf0b
Compare
Summary: this commit alters column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. The current implementation allows up to 2 decimal places. Issue: need to use more than 2 decimal places to define resources values in Quota tariff. Solution: modify column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. Values with more than 5 decimal places will be displayed with scientific notation in the user interface. SQL command: "ALTER TABLE cloud_usage.quota_tariff MODIFY currency_value DECIMAL(15,5) not null"
bb2cf0b
to
1ea1bc3
Compare
Thanks for the review @rhtyd and @rafaelweingartner ! |
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests:
Skipped tests: Passed test suits: |
@DaanHoogland or @swill can one of will merge this one? |
LGTM, a db change validated with Travis and BVT is okay. |
Summary: this commit alters column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. The current implementation allows up to 2 decimal places.
Issue: need to use more than 2 decimal places to define resources values in Quota tariff.
Solution: modify column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. Values with more than 5 decimal places will be displayed with scientific notation in the user interface.
SQL command: "ALTER TABLE cloud_usage.quota_tariff MODIFY currency_value DECIMAL(15,5) not null"