Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9914: update Quota plugin to support currency values up to 5 decimal places #2123

Merged
merged 1 commit into from Aug 23, 2017

Conversation

GabrielBrascher
Copy link
Member

@GabrielBrascher GabrielBrascher commented May 19, 2017

Summary: this commit alters column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. The current implementation allows up to 2 decimal places.

Issue: need to use more than 2 decimal places to define resources values in Quota tariff.

Solution: modify column currency_value from table cloud_usage.quota_tariff to support values up to 5 decimal places. Values with more than 5 decimal places will be displayed with scientific notation in the user interface.

SQL command: "ALTER TABLE cloud_usage.quota_tariff MODIFY currency_value DECIMAL(15,5) not null"

Copy link
Member

@rafaelweingartner rafaelweingartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud
Copy link
Member

LGTM

Summary: this commit alters column currency_value from table
cloud_usage.quota_tariff to support values up to 5 decimal places. The
current implementation allows up to 2 decimal places.

Issue: need to use more than 2 decimal places to define resources values
in Quota tariff.

Solution: modify column currency_value from table
cloud_usage.quota_tariff to support values up to 5 decimal places.
Values with more than 5 decimal places will be displayed with scientific
notation in the user interface.

SQL command: "ALTER TABLE cloud_usage.quota_tariff MODIFY currency_value
DECIMAL(15,5) not null"
@GabrielBrascher
Copy link
Member Author

Thanks for the review @rhtyd and @rafaelweingartner !

@cloudmonger
Copy link

ACS CI BVT Run

Sumarry:
Build Number 1019
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=7
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_reset_vm_on_reboot.py

  • ContextSuite context=TestResetVmOnReboot>:setup Failing since 15 runs

  • test_deploy_vm_iso.py

  • test_deploy_vm_from_iso Failing since 74 runs

  • test_vm_life_cycle.py

  • test_10_attachAndDetach_iso Failing since 74 runs

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 107 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 107 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 105 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 105 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

@rafaelweingartner
Copy link
Member

@DaanHoogland or @swill can one of will merge this one?
Everything seems to be ok, but I am not able to execute merges.

@rohityadavcloud
Copy link
Member

LGTM, a db change validated with Travis and BVT is okay.

@rohityadavcloud rohityadavcloud merged commit 57255ac into apache:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants