Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for an issue introduced in this commit: 336df84f1787de962a67d0a34… #2141

Closed
wants to merge 2 commits into from
Closed

Fix for an issue introduced in this commit: 336df84f1787de962a67d0a34… #2141

wants to merge 2 commits into from

Conversation

mike-tutkowski
Copy link
Member

@mike-tutkowski mike-tutkowski commented Jun 10, 2017 •
edited

…551f9027303040e and also a fix for VMware + managed storage

@mike-tutkowski
Copy link
Member Author

All managed-storage tests pass successfully:

TestAddRemoveHosts.py:

test_add_remove_host_with_solidfire_plugin_1 (TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName: test_add_remove_host_with_solidfire_plugin_1 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_2 (TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName: test_add_remove_host_with_solidfire_plugin_2 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_3 (TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName: test_add_remove_host_with_solidfire_plugin_3 | Status : SUCCESS ===
ok
test_add_remove_host_with_solidfire_plugin_4 (TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName: test_add_remove_host_with_solidfire_plugin_4 | Status : SUCCESS ===
ok

Ran 4 tests in 3036.238s

OK

TestManagedSystemVMs.py:

test_01_create_system_vms_on_managed_storage (TestManagedSystemVMs.TestManagedSystemVMs) ... === TestName: test_01_create_system_vms_on_managed_storage | Status : SUCCESS ===
ok
test_02_failure_to_create_service_offering_with_customized_iops (TestManagedSystemVMs.TestManagedSystemVMs) ... === TestName: test_02_failure_to_create_service_offering_with_customized_iops | Status : SUCCESS ===
ok

Ran 2 tests in 1864.418s

OK

TestVMMigrationWithStorage.py:

test_01_storage_migrate_root_and_data_disks (TestVMMigrationWithStorage.TestVMMigrationWithStorage) ... === TestName: test_01_storage_migrate_root_and_data_disks | Status : SUCCESS ===
ok
test_02_storage_migrate_root_and_data_disks (TestVMMigrationWithStorage.TestVMMigrationWithStorage) ... === TestName: test_02_storage_migrate_root_and_data_disks | Status : SUCCESS ===
ok
test_03_storage_migrate_root_and_data_disks_fail (TestVMMigrationWithStorage.TestVMMigrationWithStorage) ... === TestName: test_03_storage_migrate_root_and_data_disks_fail | Status : SUCCESS ===
ok
test_04_storage_migrate_root_disk_fails (TestVMMigrationWithStorage.TestVMMigrationWithStorage) ... === TestName: test_04_storage_migrate_root_disk_fails | Status : SUCCESS ===
ok
test_05_storage_migrate_data_disk_fails (TestVMMigrationWithStorage.TestVMMigrationWithStorage) ... === TestName: test_05_storage_migrate_data_disk_fails | Status : SUCCESS ===
ok

Ran 5 tests in 2346.416s

OK

TestVMSnapshots.py:

test_01_take_VM_snapshot (TestVMSnapshots.TestVMSnapshots) ... === TestName: test_01_take_VM_snapshot | Status : SUCCESS ===
ok
test_02_take_VM_snapshot_with_data_disk (TestVMSnapshots.TestVMSnapshots) ... === TestName: test_02_take_VM_snapshot_with_data_disk | Status : SUCCESS ===
ok

Ran 2 tests in 869.646s

OK

TestVolumes.py (no resign):

test_00_check_template_cache (TestVolumes.TestVolumes) ... === TestName: test_00_check_template_cache | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... === TestName: test_01_attach_new_volume_to_stopped_VM | Status : SUCCESS ===
ok
Attach, detach, and attach volume to a running VM ... === TestName: test_02_attach_detach_attach_volume | Status : SUCCESS ===
ok
Attach volume to running VM, then reboot. ... === TestName: test_03_attached_volume_reboot_VM | Status : SUCCESS ===
ok
Detach volume from a running VM, then reboot. ... === TestName: test_04_detach_volume_reboot | Status : SUCCESS ===
ok
Detach volume from a stopped VM, then start. ... === TestName: test_05_detach_vol_stopped_VM_start | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... === TestName: test_06_attach_volume_to_stopped_VM | Status : SUCCESS ===
ok
Destroy and expunge VM with attached volume ... === TestName: test_07_destroy_expunge_VM_with_volume | Status : SUCCESS ===
ok
Delete volume that was attached to a VM and is detached now ... === TestName: test_08_delete_volume_was_attached | Status : SUCCESS ===
ok
Attach a data disk to a VM in one account and attach another data disk to a VM in another account ... === TestName: test_09_attach_volumes_multiple_accounts | Status : SUCCESS ===
ok
Attach more than one disk to a VM ... === TestName: test_10_attach_more_than_one_disk_to_VM | Status : SUCCESS ===
ok

Ran 11 tests in 1326.838s

OK

TestVolumes.py (resign):

test_00_check_template_cache (TestVolumes.TestVolumes) ... === TestName: test_00_check_template_cache | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... === TestName: test_01_attach_new_volume_to_stopped_VM | Status : SUCCESS ===
ok
Attach, detach, and attach volume to a running VM ... === TestName: test_02_attach_detach_attach_volume | Status : SUCCESS ===
ok
Attach volume to running VM, then reboot. ... === TestName: test_03_attached_volume_reboot_VM | Status : SUCCESS ===
ok
Detach volume from a running VM, then reboot. ... === TestName: test_04_detach_volume_reboot | Status : SUCCESS ===
ok
Detach volume from a stopped VM, then start. ... === TestName: test_05_detach_vol_stopped_VM_start | Status : SUCCESS ===
ok
Attach a volume to a stopped virtual machine, then start VM ... === TestName: test_06_attach_volume_to_stopped_VM | Status : SUCCESS ===
ok
Destroy and expunge VM with attached volume ... === TestName: test_07_destroy_expunge_VM_with_volume | Status : SUCCESS ===
ok
Delete volume that was attached to a VM and is detached now ... === TestName: test_08_delete_volume_was_attached | Status : SUCCESS ===
ok
Attach a data disk to a VM in one account and attach another data disk to a VM in another account ... === TestName: test_09_attach_volumes_multiple_accounts | Status : SUCCESS ===
ok
Attach more than one disk to a VM ... === TestName: test_10_attach_more_than_one_disk_to_VM | Status : SUCCESS ===
ok

Ran 11 tests in 1547.541s

OK

TestSnapshots.py (environment issued caused a failure in two tests, which I ran again and they passed):

test_01_create_volume_snapshot_using_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_01_create_volume_snapshot_using_sf_snapshot | Status : SUCCESS ===
ok
test_02_create_volume_snapshot_using_sf_volume (TestSnapshots.TestSnapshots) ... === TestName: test_02_create_volume_snapshot_using_sf_volume | Status : SUCCESS ===
ok
test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot | Status : EXCEPTION ===
ERROR
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving (TestSnapshots.TestSnapshots) ... === TestName: test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status : EXCEPTION ===
ERROR
test_05_create_volume_snapshot_using_sf_snapshot_and_revert_volume_to_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_05_create_volume_snapshot_using_sf_snapshot_and_revert_volume_to_snapshot | Status : SUCCESS ===
ok

Re-run of the two tests that failed for environmental reasons (now passed):

test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot | Status : SUCCESS ===
ok
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving (TestSnapshots.TestSnapshots) ... === TestName: test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status : SUCCESS ===
ok

Ran 2 tests in 2952.535s

OK

@wido
Copy link
Contributor

wido commented Jun 12, 2017

Can't really say much about the code, but @karuturi , could you take a look? As this is a -1 by Mike now.

@wido wido added this to the 4.10.0.0 milestone Jun 12, 2017
@borisstoyanov
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-764

@borisstoyanov
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1152)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30719 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2141-t1152-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Test completed. 50 look ok, 1 have error(s)

Test Result Time (s) Test File
test_04_rvpc_privategw_static_routes Failure 320.58 test_privategw_acl.py
test_01_vpc_site2site_vpn Success 149.86 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Success 56.11 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Success 225.36 test_vpc_vpn.py
test_02_VPC_default_routes Success 282.22 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Success 528.63 test_vpc_router_nics.py
test_05_rvpc_multi_tiers Success 507.83 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Success 1304.69 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Success 552.78 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Success 743.12 test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Success 1262.15 test_vpc_redundant.py
test_09_delete_detached_volume Success 151.64 test_volumes.py
test_08_resize_volume Success 156.52 test_volumes.py
test_07_resize_fail Success 161.58 test_volumes.py
test_06_download_detached_volume Success 156.35 test_volumes.py
test_05_detach_volume Success 140.66 test_volumes.py
test_04_delete_attached_volume Success 151.21 test_volumes.py
test_03_download_attached_volume Success 156.27 test_volumes.py
test_02_attach_volume Success 84.14 test_volumes.py
test_01_create_volume Success 712.41 test_volumes.py
test_03_delete_vm_snapshots Success 275.21 test_vm_snapshots.py
test_02_revert_vm_snapshots Success 95.77 test_vm_snapshots.py
test_01_create_vm_snapshots Success 133.71 test_vm_snapshots.py
test_deploy_vm_multiple Success 272.86 test_vm_life_cycle.py
test_deploy_vm Success 0.03 test_vm_life_cycle.py
test_advZoneVirtualRouter Success 0.02 test_vm_life_cycle.py
test_10_attachAndDetach_iso Success 26.84 test_vm_life_cycle.py
test_09_expunge_vm Success 125.16 test_vm_life_cycle.py
test_08_migrate_vm Success 30.97 test_vm_life_cycle.py
test_07_restore_vm Success 0.17 test_vm_life_cycle.py
test_06_destroy_vm Success 125.88 test_vm_life_cycle.py
test_03_reboot_vm Success 125.83 test_vm_life_cycle.py
test_02_start_vm Success 10.17 test_vm_life_cycle.py
test_01_stop_vm_forced Success 5.16 test_vm_life_cycle.py
test_01_stop_vm Success 35.30 test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName Success 30.42 test_templates.py
test_08_list_system_templates Success 0.04 test_templates.py
test_07_list_public_templates Success 0.05 test_templates.py
test_05_template_permissions Success 0.07 test_templates.py
test_04_extract_template Success 5.18 test_templates.py
test_03_delete_template Success 5.11 test_templates.py
test_02_edit_template Success 90.17 test_templates.py
test_01_create_template Success 20.33 test_templates.py
test_10_destroy_cpvm Success 161.76 test_ssvm.py
test_09_destroy_ssvm Success 163.80 test_ssvm.py
test_08_reboot_cpvm Success 131.60 test_ssvm.py
test_07_reboot_ssvm Success 102.95 test_ssvm.py
test_06_stop_cpvm Success 131.83 test_ssvm.py
test_05_stop_ssvm Success 133.13 test_ssvm.py
test_04_cpvm_internals Success 1.25 test_ssvm.py
test_03_ssvm_internals Success 2.77 test_ssvm.py
test_02_list_cpvm_vm Success 0.15 test_ssvm.py
test_01_list_sec_storage_vm Success 0.13 test_ssvm.py
test_02_list_snapshots_with_removed_data_store Success 81.75 test_snapshots.py
test_01_snapshot_root_disk Success 11.18 test_snapshots.py
test_04_change_offering_small Success 239.72 test_service_offerings.py
test_03_delete_service_offering Success 0.04 test_service_offerings.py
test_02_edit_service_offering Success 0.07 test_service_offerings.py
test_01_create_service_offering Success 0.10 test_service_offerings.py
test_02_sys_template_ready Success 0.14 test_secondary_storage.py
test_01_sys_vm_start Success 0.18 test_secondary_storage.py
test_09_reboot_router Success 35.30 test_routers.py
test_08_start_router Success 30.28 test_routers.py
test_07_stop_router Success 10.16 test_routers.py
test_06_router_advanced Success 0.06 test_routers.py
test_05_router_basic Success 0.04 test_routers.py
test_04_restart_network_wo_cleanup Success 5.72 test_routers.py
test_03_restart_network_cleanup Success 60.52 test_routers.py
test_02_router_internal_adv Success 0.84 test_routers.py
test_01_router_internal_basic Success 0.45 test_routers.py
test_router_dns_guestipquery Success 73.74 test_router_dns.py
test_router_dns_externalipquery Success 0.08 test_router_dns.py
test_router_dhcphosts Success 242.09 test_router_dhcphosts.py
test_router_dhcp_opts Success 21.75 test_router_dhcphosts.py
test_01_updatevolumedetail Success 0.10 test_resource_detail.py
test_01_reset_vm_on_reboot Success 130.89 test_reset_vm_on_reboot.py
test_createRegion Success 0.04 test_regions.py
test_create_pvlan_network Success 5.22 test_pvlan.py
test_dedicatePublicIpRange Success 0.42 test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup Success 490.41 test_privategw_acl.py
test_02_vpc_privategw_static_routes Success 375.49 test_privategw_acl.py
test_01_vpc_privategw_acl Success 97.18 test_privategw_acl.py
test_03_migration_options_storage_tags Success 66.02 test_primary_storage.py
test_02_edit_primary_storage_tags Success 0.10 test_primary_storage.py
test_01_primary_storage_nfs Success 35.80 test_primary_storage.py
test_01_deploy_vms_storage_tags Success 31.08 test_primary_storage.py
test_createPortablePublicIPRange Success 15.18 test_portable_publicip.py
test_createPortablePublicIPAcquire Success 15.44 test_portable_publicip.py
test_isolate_network_password_server Success 89.38 test_password_server.py
test_UpdateStorageOverProvisioningFactor Success 0.12 test_over_provisioning.py
test_oobm_zchange_password Success 25.60 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Success 16.35 test_outofbandmanagement.py
test_oobm_issue_power_status Success 10.27 test_outofbandmanagement.py
test_oobm_issue_power_soft Success 10.33 test_outofbandmanagement.py
test_oobm_issue_power_reset Success 15.37 test_outofbandmanagement.py
test_oobm_issue_power_on Success 15.33 test_outofbandmanagement.py
test_oobm_issue_power_off Success 10.30 test_outofbandmanagement.py
test_oobm_issue_power_cycle Success 15.38 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Success 87.61 test_outofbandmanagement.py
test_oobm_enable_feature_valid Success 5.16 test_outofbandmanagement.py
test_oobm_enable_feature_invalid Success 0.10 test_outofbandmanagement.py
test_oobm_disable_feature_valid Success 0.16 test_outofbandmanagement.py
test_oobm_disable_feature_invalid Success 0.13 test_outofbandmanagement.py
test_oobm_configure_invalid_driver Success 0.10 test_outofbandmanagement.py
test_oobm_configure_default_driver Success 0.09 test_outofbandmanagement.py
test_oobm_background_powerstate_sync Success 23.40 test_outofbandmanagement.py
test_extendPhysicalNetworkVlan Success 15.31 test_non_contigiousvlan.py
test_01_nic Success 389.05 test_nic.py
test_releaseIP Success 232.72 test_network.py
test_reboot_router Success 448.85 test_network.py
test_public_ip_user_account Success 10.35 test_network.py
test_public_ip_admin_account Success 40.27 test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Success 66.72 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Success 61.59 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Success 123.41 test_network.py
test_delete_account Success 252.60 test_network.py
test_02_port_fwd_on_non_src_nat Success 55.66 test_network.py
test_01_port_fwd_on_src_nat Success 112.44 test_network.py
test_nic_secondaryip_add_remove Success 267.93 test_multipleips_per_nic.py
test_list_zones_metrics Success 0.23 test_metrics_api.py
test_list_volumes_metrics Success 0.53 test_metrics_api.py
test_list_vms_metrics Success 191.61 test_metrics_api.py
test_list_pstorage_metrics Success 0.32 test_metrics_api.py
test_list_infrastructure_metrics Success 0.41 test_metrics_api.py
test_list_hosts_metrics Success 0.40 test_metrics_api.py
test_list_clusters_metrics Success 0.33 test_metrics_api.py
login_test_saml_user Success 19.19 test_login.py
test_assign_and_removal_lb Success 134.95 test_loadbalance.py
test_02_create_lb_rule_non_nat Success 188.10 test_loadbalance.py
test_01_create_lb_rule_src_nat Success 198.49 test_loadbalance.py
test_03_list_snapshots Success 0.09 test_list_ids_parameter.py
test_02_list_templates Success 0.04 test_list_ids_parameter.py
test_01_list_volumes Success 0.03 test_list_ids_parameter.py
test_07_list_default_iso Success 0.06 test_iso.py
test_05_iso_permissions Success 0.06 test_iso.py
test_04_extract_Iso Success 5.16 test_iso.py
test_03_delete_iso Success 95.19 test_iso.py
test_02_edit_iso Success 0.09 test_iso.py
test_01_create_iso Success 21.01 test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Success 197.94 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Success 168.16 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Success 478.34 test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Success 403.27 test_internal_lb.py
test_dedicateGuestVlanRange Success 10.32 test_guest_vlan_range.py
test_UpdateConfigParamWithScope Success 0.14 test_global_settings.py
test_rolepermission_lifecycle_update Success 6.16 test_dynamicroles.py
test_rolepermission_lifecycle_list Success 5.97 test_dynamicroles.py
test_rolepermission_lifecycle_delete Success 5.84 test_dynamicroles.py
test_rolepermission_lifecycle_create Success 5.86 test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates Success 5.99 test_dynamicroles.py
test_role_lifecycle_update_role_inuse Success 5.89 test_dynamicroles.py
test_role_lifecycle_update Success 11.05 test_dynamicroles.py
test_role_lifecycle_list Success 5.87 test_dynamicroles.py
test_role_lifecycle_delete Success 5.89 test_dynamicroles.py
test_role_lifecycle_create Success 5.90 test_dynamicroles.py
test_role_inuse_deletion Success 5.86 test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers Success 8.17 test_dynamicroles.py
test_role_account_acls Success 8.58 test_dynamicroles.py
test_default_role_deletion Success 6.20 test_dynamicroles.py
test_04_create_fat_type_disk_offering Success 0.09 test_disk_offerings.py
test_03_delete_disk_offering Success 0.04 test_disk_offerings.py
test_02_edit_disk_offering Success 0.07 test_disk_offerings.py
test_02_create_sparse_type_disk_offering Success 0.07 test_disk_offerings.py
test_01_create_disk_offering Success 0.11 test_disk_offerings.py
test_deployvm_userdispersing Success 20.58 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated Success 20.59 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit Success 65.76 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post Success 10.42 test_deploy_vm_with_userdata.py
test_deployvm_userdata Success 60.78 test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize Success 0.07 test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize Success 0.07 test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize Success 181.47 test_deploy_vm_root_resize.py
test_deploy_vm_from_iso Success 192.39 test_deploy_vm_iso.py
test_06_verify_guest_lspci_again Success 40.47 test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart Success 16.00 test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci Success 40.38 test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk Success 10.77 test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart Success 136.64 test_deploy_virtio_scsi_vm.py
test_01_verify_libvirt Success 0.50 test_deploy_virtio_scsi_vm.py
test_DeployVmAntiAffinityGroup Success 60.98 test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.02 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.03 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.04 test_primary_storage.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.03 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.03 test_deploy_vgpu_enabled_vm.py

@karuturi
Copy link
Member

need another LGTM. @borisstoyanov @rhtyd @anshul-gangwar Can you review?

@karuturi
Copy link
Member

@mike-tutkowski
I see some failures in the posted test results. Are they related?
test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot | Status : EXCEPTION ===
ERROR
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving (TestSnapshots.TestSnapshots) ... === TestName: test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status : EXCEPTION ===
ERROR

@anshul1886
Copy link

code LGTM.
My bad missed the managed storage part.

@rohityadavcloud
Copy link
Member

Should n't this be targeted against master? /cc @mike-tutkowski

@mike-tutkowski
Copy link
Member Author

Hi @karuturi - Yeah, I had noted those failed for environmental reasons. I had re-run them successfully. Here is a copy/paste from above:

Re-run of the two tests that failed for environmental reasons (now passed):

test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName: test_03_create_volume_snapshot_using_sf_volume_and_sf_snapshot | Status : SUCCESS ===
ok
test_04_create_volume_snapshot_using_sf_snapshot_and_archiving (TestSnapshots.TestSnapshots) ... === TestName: test_04_create_volume_snapshot_using_sf_snapshot_and_archiving | Status : SUCCESS ===
ok

@karuturi
Copy link
Member

@mike-tutkowski Can you rebase this to master?

@mike-tutkowski mike-tutkowski deleted the 4.10.0.0-RC20170609T1354 branch June 14, 2017 11:41
@mike-tutkowski mike-tutkowski restored the 4.10.0.0-RC20170609T1354 branch June 14, 2017 11:42
@mike-tutkowski mike-tutkowski mentioned this pull request Jun 14, 2017
Closed
@mike-tutkowski
Copy link
Member Author

mike-tutkowski commented Jun 14, 2017 via email

@karuturi karuturi mentioned this pull request Jun 19, 2017
Merged
@mike-tutkowski mike-tutkowski deleted the 4.10.0.0-RC20170609T1354 branch June 20, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Severity:BLOCKER
Projects
None yet
Milestone
4.10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mike-tutkowski @wido @borisstoyanov @blueorangutan @karuturi @anshul1886 @rohityadavcloud