CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanaravapalli
changed the title
pavanaravapalli
changed the title
wido
reviewed
Jun 16, 2017
| volumeCheck = _volumeDetailsDaoImpl.findDetails("SNAPSHOT_ID", String.valueOf(snapshotId), null); | ||
|
|
||
| if (volumeCheck.size() > 0) { | ||
| throw new InvalidParameterValueException("Unable to perform delete operation, Snapshot with id: " + snapshotId + " is in using "); |
There was a problem hiding this comment.
Could you change "is in using" to "is in use" ? That would be a better log line
There was a problem hiding this comment.
@wido changes done as suggested
| @@ -530,6 +534,13 @@ public boolean deleteSnapshot(long snapshotId) { | |||
| return false; | |||
| } | |||
|
|
|||
| List<VolumeDetailVO> volumeCheck; | |||
There was a problem hiding this comment.
Can you update the variable name to more meaningful. eg: volumesFromSnapshot, volumesFromSnapshotCheck,...
There was a problem hiding this comment.
@sureshanaparti changes done as suggested
| if (volumeCheck.size() > 0) { | ||
| throw new InvalidParameterValueException("Unable to perform delete operation, Snapshot with id: " + snapshotId + " is in use "); | ||
| } | ||
|
|
There was a problem hiding this comment.
Any other approach to check the volumes creating from a given snapshot?
There was a problem hiding this comment.
When a volume created from snapshot, we are not maintaining volume in relation to snapshot details anywhere in database. It's been recently integrated and information stored in VOLUME_DETAILS table.
Data/Records in this table will be persist till volume creation operation finish(success/failure). Once volume operation done this record will be removed. I have not come across alternatives other than this approach.
There was a problem hiding this comment.
@pavanaravapalli thanks for the confirmation.
|
Code changes LGTM. |
| List<VolumeDetailVO> volumesFromSnapshot; | ||
| volumesFromSnapshot = _volumeDetailsDaoImpl.findDetails("SNAPSHOT_ID", String.valueOf(snapshotId), null); | ||
|
|
||
| if (volumesFromSnapshot.size() > 0) { |
There was a problem hiding this comment.
There could be race condition here. After volumesFromSnapshot = 0, a new volume can be created from snapshot, before the snapshot is actually deleted.
There was a problem hiding this comment.
@kishankavala race condition problem handled and, code changes done accordingly
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-793 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1194)
|
borisstoyanov
approved these changes
Jul 5, 2017
|
@pavanaravapalli please fix the conflicts |
|
@pavanaravapalli please rebase and fix conflicts |
|
@rhtyd ok I will do . |
|
@pavanaravapalli can you fix the conflicts? |
…reation from the snapshot is in progress
|
@rhtyd rebased and fixed conflicts |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1426 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1497 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1513 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1553 |
|
@blueorangutan test centos7 xenserver-65sp1 |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests |
|
Trillian test result (tid-1989)
|
|
Merging this based on code reviews and test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to check if any volume(s) are in creating state , before performing delete snapshot.