Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values #2168

Merged
merged 1 commit into from
Jul 24, 2017
Merged

CLOUDSTACK-9986: Consider overcommit ratios with total/threshold values #2168

merged 1 commit into from
Jul 24, 2017

Conversation

rohityadavcloud
Copy link
Member

Consider the CPU and memory overcommit ratios with total cpu/ram values
or thresholds for host and cluster metrics. This will fix incorrect
notification (cells turning yellow/red) in the metrics view.

Pinging for review - @borisstoyanov @DaanHoogland and others.

@rohityadavcloud rohityadavcloud force-pushed the metrics-fix-allocated-thresholds branch from 873cfb1 to 5e3646f Compare July 14, 2017 10:52
@rohityadavcloud
FIX3: Consider overcommit ratios with total/threshold values for host…
6220187 
… metrics

Consider the CPU and memory overcommit ratios with total cpu/ram values
or thresholds for host metrics. This will fix incorrect notification
(cells turning yellow/red) in the metrics view.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud rohityadavcloud force-pushed the metrics-fix-allocated-thresholds branch from 5e3646f to 6220187 Compare July 22, 2017 11:16
@cloudmonger
Copy link

ACS CI BVT Run

Sumarry:
Build Number 999
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=9
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_scale_vm.py

  • ContextSuite context=TestScaleVm>:setup Failing since 31 runs

  • test_non_contigiousvlan.py

  • test_extendPhysicalNetworkVlan Failed

  • test_deploy_vm_iso.py

  • test_deploy_vm_from_iso Failing since 56 runs

  • test_volumes.py

  • test_06_download_detached_volume Failing since 3 runs

  • test_vm_life_cycle.py

  • test_10_attachAndDetach_iso Failing since 56 runs

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 89 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 89 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 87 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 87 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-833

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1235)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2168-t1235-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 47 look ok, 2 have error(s)

Test Result Time (s) Test File
test_04_rvpc_privategw_static_routes Failure 421.34 test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store Error 0.06 test_snapshots.py
test_01_vpc_site2site_vpn Success 144.84 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Success 61.23 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Success 255.72 test_vpc_vpn.py
test_02_VPC_default_routes Success 254.35 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Success 553.76 test_vpc_router_nics.py
test_05_rvpc_multi_tiers Success 510.06 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Success 1433.36 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Success 557.80 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Success 733.05 test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Success 1282.81 test_vpc_redundant.py
test_09_delete_detached_volume Success 151.53 test_volumes.py
test_08_resize_volume Success 156.54 test_volumes.py
test_07_resize_fail Success 156.49 test_volumes.py
test_06_download_detached_volume Success 151.36 test_volumes.py
test_05_detach_volume Success 140.72 test_volumes.py
test_04_delete_attached_volume Success 151.24 test_volumes.py
test_03_download_attached_volume Success 156.37 test_volumes.py
test_02_attach_volume Success 84.39 test_volumes.py
test_01_create_volume Success 616.94 test_volumes.py
test_deploy_vm_multiple Success 273.32 test_vm_life_cycle.py
test_deploy_vm Success 0.03 test_vm_life_cycle.py
test_advZoneVirtualRouter Success 0.03 test_vm_life_cycle.py
test_10_attachAndDetach_iso Success 26.73 test_vm_life_cycle.py
test_09_expunge_vm Success 125.17 test_vm_life_cycle.py
test_08_migrate_vm Success 36.02 test_vm_life_cycle.py
test_07_restore_vm Success 0.15 test_vm_life_cycle.py
test_06_destroy_vm Success 125.88 test_vm_life_cycle.py
test_03_reboot_vm Success 125.96 test_vm_life_cycle.py
test_02_start_vm Success 10.18 test_vm_life_cycle.py
test_01_stop_vm_forced Success 5.15 test_vm_life_cycle.py
test_01_stop_vm Success 35.29 test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName Success 90.74 test_templates.py
test_08_list_system_templates Success 0.03 test_templates.py
test_07_list_public_templates Success 0.05 test_templates.py
test_05_template_permissions Success 0.06 test_templates.py
test_04_extract_template Success 5.21 test_templates.py
test_03_delete_template Success 5.13 test_templates.py
test_02_edit_template Success 90.14 test_templates.py
test_01_create_template Success 95.75 test_templates.py
test_10_destroy_cpvm Success 161.75 test_ssvm.py
test_09_destroy_ssvm Success 193.84 test_ssvm.py
test_08_reboot_cpvm Success 101.46 test_ssvm.py
test_07_reboot_ssvm Success 103.18 test_ssvm.py
test_06_stop_cpvm Success 131.55 test_ssvm.py
test_05_stop_ssvm Success 133.32 test_ssvm.py
test_04_cpvm_internals Success 0.96 test_ssvm.py
test_03_ssvm_internals Success 3.30 test_ssvm.py
test_02_list_cpvm_vm Success 0.13 test_ssvm.py
test_01_list_sec_storage_vm Success 0.16 test_ssvm.py
test_01_snapshot_root_disk Success 16.19 test_snapshots.py
test_04_change_offering_small Success 209.74 test_service_offerings.py
test_03_delete_service_offering Success 0.06 test_service_offerings.py
test_02_edit_service_offering Success 0.09 test_service_offerings.py
test_01_create_service_offering Success 0.11 test_service_offerings.py
test_02_sys_template_ready Success 0.15 test_secondary_storage.py
test_01_sys_vm_start Success 0.21 test_secondary_storage.py
test_09_reboot_router Success 40.36 test_routers.py
test_08_start_router Success 35.32 test_routers.py
test_07_stop_router Success 10.20 test_routers.py
test_06_router_advanced Success 0.06 test_routers.py
test_05_router_basic Success 0.04 test_routers.py
test_04_restart_network_wo_cleanup Success 5.77 test_routers.py
test_03_restart_network_cleanup Success 65.59 test_routers.py
test_02_router_internal_adv Success 0.89 test_routers.py
test_01_router_internal_basic Success 0.50 test_routers.py
test_router_dns_guestipquery Success 74.33 test_router_dns.py
test_router_dns_externalipquery Success 0.07 test_router_dns.py
test_router_dhcphosts Success 242.78 test_router_dhcphosts.py
test_router_dhcp_opts Success 21.65 test_router_dhcphosts.py
test_01_updatevolumedetail Success 5.13 test_resource_detail.py
test_01_reset_vm_on_reboot Success 130.98 test_reset_vm_on_reboot.py
test_createRegion Success 0.04 test_regions.py
test_create_pvlan_network Success 5.22 test_pvlan.py
test_dedicatePublicIpRange Success 0.43 test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup Success 465.49 test_privategw_acl.py
test_02_vpc_privategw_static_routes Success 385.85 test_privategw_acl.py
test_01_vpc_privategw_acl Success 92.41 test_privategw_acl.py
test_01_primary_storage_nfs Success 35.92 test_primary_storage.py
test_createPortablePublicIPRange Success 15.20 test_portable_publicip.py
test_createPortablePublicIPAcquire Success 15.49 test_portable_publicip.py
test_isolate_network_password_server Success 60.78 test_password_server.py
test_UpdateStorageOverProvisioningFactor Success 0.13 test_over_provisioning.py
test_oobm_zchange_password Success 30.83 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Success 16.38 test_outofbandmanagement.py
test_oobm_issue_power_status Success 5.22 test_outofbandmanagement.py
test_oobm_issue_power_soft Success 15.37 test_outofbandmanagement.py
test_oobm_issue_power_reset Success 10.33 test_outofbandmanagement.py
test_oobm_issue_power_on Success 15.36 test_outofbandmanagement.py
test_oobm_issue_power_off Success 15.35 test_outofbandmanagement.py
test_oobm_issue_power_cycle Success 10.37 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Success 87.74 test_outofbandmanagement.py
test_oobm_enable_feature_valid Success 0.16 test_outofbandmanagement.py
test_oobm_enable_feature_invalid Success 0.11 test_outofbandmanagement.py
test_oobm_disable_feature_valid Success 0.18 test_outofbandmanagement.py
test_oobm_disable_feature_invalid Success 0.12 test_outofbandmanagement.py
test_oobm_configure_invalid_driver Success 0.09 test_outofbandmanagement.py
test_oobm_configure_default_driver Success 0.09 test_outofbandmanagement.py
test_oobm_background_powerstate_sync Success 23.55 test_outofbandmanagement.py
test_extendPhysicalNetworkVlan Success 15.31 test_non_contigiousvlan.py
test_01_nic Success 459.51 test_nic.py
test_releaseIP Success 197.76 test_network.py
test_reboot_router Success 449.17 test_network.py
test_public_ip_user_account Success 10.29 test_network.py
test_public_ip_admin_account Success 40.33 test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Success 66.73 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Success 61.52 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Success 120.89 test_network.py
test_delete_account Success 368.40 test_network.py
test_02_port_fwd_on_non_src_nat Success 55.66 test_network.py
test_01_port_fwd_on_src_nat Success 108.88 test_network.py
test_nic_secondaryip_add_remove Success 217.71 test_multipleips_per_nic.py
test_list_zones_metrics Success 0.34 test_metrics_api.py
test_list_volumes_metrics Success 5.54 test_metrics_api.py
test_list_vms_metrics Success 247.26 test_metrics_api.py
test_list_pstorage_metrics Success 0.37 test_metrics_api.py
test_list_infrastructure_metrics Success 0.53 test_metrics_api.py
test_list_hosts_metrics Success 0.38 test_metrics_api.py
test_list_clusters_metrics Success 0.34 test_metrics_api.py
login_test_saml_user Success 19.34 test_login.py
test_assign_and_removal_lb Success 136.36 test_loadbalance.py
test_02_create_lb_rule_non_nat Success 188.22 test_loadbalance.py
test_01_create_lb_rule_src_nat Success 229.57 test_loadbalance.py
test_03_list_snapshots Success 0.08 test_list_ids_parameter.py
test_02_list_templates Success 0.04 test_list_ids_parameter.py
test_01_list_volumes Success 0.03 test_list_ids_parameter.py
test_07_list_default_iso Success 0.06 test_iso.py
test_05_iso_permissions Success 0.06 test_iso.py
test_04_extract_Iso Success 5.15 test_iso.py
test_03_delete_iso Success 95.19 test_iso.py
test_02_edit_iso Success 0.09 test_iso.py
test_01_create_iso Success 21.02 test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Success 203.06 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Success 132.60 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Success 549.95 test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Success 438.93 test_internal_lb.py
test_dedicateGuestVlanRange Success 10.31 test_guest_vlan_range.py
test_UpdateConfigParamWithScope Success 0.14 test_global_settings.py
test_rolepermission_lifecycle_update Success 6.17 test_dynamicroles.py
test_rolepermission_lifecycle_list Success 6.03 test_dynamicroles.py
test_rolepermission_lifecycle_delete Success 5.86 test_dynamicroles.py
test_rolepermission_lifecycle_create Success 5.89 test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates Success 6.01 test_dynamicroles.py
test_role_lifecycle_update_role_inuse Success 5.94 test_dynamicroles.py
test_role_lifecycle_update Success 10.97 test_dynamicroles.py
test_role_lifecycle_list Success 5.88 test_dynamicroles.py
test_role_lifecycle_delete Success 10.94 test_dynamicroles.py
test_role_lifecycle_create Success 5.92 test_dynamicroles.py
test_role_inuse_deletion Success 5.88 test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers Success 8.21 test_dynamicroles.py
test_role_account_acls Success 8.46 test_dynamicroles.py
test_default_role_deletion Success 6.08 test_dynamicroles.py
test_04_create_fat_type_disk_offering Success 0.08 test_disk_offerings.py
test_03_delete_disk_offering Success 0.04 test_disk_offerings.py
test_02_edit_disk_offering Success 0.05 test_disk_offerings.py
test_02_create_sparse_type_disk_offering Success 0.07 test_disk_offerings.py
test_01_create_disk_offering Success 0.10 test_disk_offerings.py
test_deployvm_userdispersing Success 20.58 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated Success 91.12 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit Success 75.98 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post Success 10.52 test_deploy_vm_with_userdata.py
test_deployvm_userdata Success 126.29 test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize Success 6.00 test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize Success 6.02 test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize Success 267.90 test_deploy_vm_root_resize.py
test_deploy_vm_from_iso Success 202.48 test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup Success 106.25 test_affinity_groups.py
test_03_delete_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_02_revert_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_01_create_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.05 test_primary_storage.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.01 test_deploy_vgpu_enabled_vm.py

@rohityadavcloud
Copy link
Member Author

Test LGTM, no new failures, existing failures are known intermittent failures.

borisstoyanov
borisstoyanov approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud rohityadavcloud merged commit 90e7cab into apache:4.9 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees
No one assigned
Labels
component:management-server type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rohityadavcloud @cloudmonger @blueorangutan @borisstoyanov @kiwiflyer