New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-10121 moveUser #2301
Conversation
@DaanHoogland can you rebase and advise if this is ready for review/test/merging? |
a0523c1
to
89736ea
Compare
@rhtyd yes, please review |
@DaanHoogland I think I've wrote a test for this, after your rebase I don't see my commit, is it possible that it's lost somehow? |
@borisstoyanov yes that might well be the only answer, sorry. Do you still have it locally? |
@DaanHoogland I think I did a bit of mess here, should we do some cherry picking to resolve this? |
54820cc
to
812f377
Compare
@borisstoyanov looks good now |
Trillian test result (tid-1796)
|
@DaanHoogland can you check failing tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test data is missing in trillian @DaanHoogland
shapeblue/Trillian#42
@borisstoyanov merged, please re-kick tests. |
Thanks @rhtyd, |
Trillian test result (tid-1842)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move user errors are sorted, rest are not related to these changes, LGTM.
Tests LGTM. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1526 |
@blueorangutan test |
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1947)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rhtyd I see two lgtm and extensive tests so I am merging but aware that we spoke about even stricter gating. please revert if you don't think this is enough. |
Lgtm, thanks. |
No description provided.