Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-10121 moveUser #2301

Merged
merged 12 commits into from Dec 30, 2017
Merged

CLOUDSTACK-10121 moveUser #2301

merged 12 commits into from Dec 30, 2017

Conversation

DaanHoogland
Copy link
Contributor

No description provided.

@DaanHoogland DaanHoogland changed the title WIP CLOUDSTACK-10121 moveUser CLOUDSTACK-10121 moveUser Nov 7, 2017
@apache apache deleted a comment from blueorangutan Nov 7, 2017
@apache apache deleted a comment from blueorangutan Nov 7, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 8, 2017
@apache apache deleted a comment from blueorangutan Nov 9, 2017
@apache apache deleted a comment from blueorangutan Nov 9, 2017
@apache apache deleted a comment from blueorangutan Nov 9, 2017
@apache apache deleted a comment from blueorangutan Nov 9, 2017
@rohityadavcloud
Copy link
Member

@DaanHoogland can you rebase and advise if this is ready for review/test/merging?

@DaanHoogland
Copy link
Contributor Author

@rhtyd yes, please review
@blueorangutan package

@borisstoyanov
Copy link
Contributor

@DaanHoogland I think I've wrote a test for this, after your rebase I don't see my commit, is it possible that it's lost somehow?

@DaanHoogland
Copy link
Contributor Author

@borisstoyanov yes that might well be the only answer, sorry. Do you still have it locally?

@borisstoyanov
Copy link
Contributor

@DaanHoogland I think I did a bit of mess here, should we do some cherry picking to resolve this?

@DaanHoogland
Copy link
Contributor Author

@borisstoyanov looks good now

@rohityadavcloud rohityadavcloud added this to the 4.11 milestone Dec 10, 2017
@blueorangutan
Copy link

Trillian test result (tid-1796)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28248 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2301-t1796-kvm-centos7.zip
Test completed. Failed tests results shown below:

Test Result Time (s) Test File
test_move_user_incorrect_account_id Error 1.27 test_accounts.py
test_move_user_incorrect_account_name Error 1.28 test_accounts.py
test_move_user_to_accountID Error 1.27 test_accounts.py
test_move_user_to_account_name Error 1.30 test_accounts.py
test_move_user_to_different_domain Error 1.28 test_accounts.py
test_01_vpc_privategw_acl Failure 61.76 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 198.44 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 133.07 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 288.96 test_privategw_acl.py
test_02_create_template_with_checksum_sha1 Error 5.24 test_templates.py
test_03_create_template_with_checksum_sha256 Error 5.22 test_templates.py
test_04_create_template_with_checksum_md5 Error 5.23 test_templates.py
test_01_vpc_remote_access_vpn Failure 61.08 test_vpc_vpn.py

@rohityadavcloud
Copy link
Member

@DaanHoogland can you check failing tests?

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test data is missing in trillian @DaanHoogland
shapeblue/Trillian#42

@rohityadavcloud
Copy link
Member

@borisstoyanov merged, please re-kick tests.

@borisstoyanov
Copy link
Contributor

Thanks @rhtyd,
@blueorangutan test

@blueorangutan
Copy link

Trillian test result (tid-1842)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2301-t1842-kvm-centos7.zip
Smoke tests completed. 62 look OK, 5 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_oobm_zchange_password Error 10.27 test_outofbandmanagement.py
test_01_vpc_privategw_acl Failure 61.84 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 279.43 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 143.66 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 435.19 test_privategw_acl.py
test_02_create_template_with_checksum_sha1 Error 5.27 test_templates.py
test_03_create_template_with_checksum_sha256 Error 5.28 test_templates.py
test_04_create_template_with_checksum_md5 Error 5.40 test_templates.py
test_01_vpc_remote_access_vpn Failure 71.14 test_vpc_vpn.py
test_hostha_kvm_host_fencing Error 1117.65 test_hostha_kvm.py

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move user errors are sorted, rest are not related to these changes, LGTM.

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Dec 21, 2017

Tests LGTM.

@apache apache deleted a comment from borisstoyanov Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from rohityadavcloud Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from rohityadavcloud Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from borisstoyanov Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from rohityadavcloud Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from rohityadavcloud Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@apache apache deleted a comment from blueorangutan Dec 29, 2017
@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1526

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1947)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2301-t1947-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland
Copy link
Contributor Author

@rhtyd I see two lgtm and extensive tests so I am merging but aware that we spoke about even stricter gating. please revert if you don't think this is enough.

@DaanHoogland DaanHoogland merged commit 6724a47 into apache:master Dec 30, 2017
@rohityadavcloud
Copy link
Member

Lgtm, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants