New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDSTACK-10173: VR's guest/public nic to pick network rate from offering #2351
Conversation
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1343 |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1732)
|
Tests LGTM, the failures are known intermittent issues and not caused by this PR. |
Per the following doc, VR's guest/public nic should pick up network rate from its network offering: http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
cee81c9
to
cc5d7f6
Compare
Updated fix /cc @borisstoyanov |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1373 |
@blueorangutan test centos7 vmware-55u3 |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
Trillian test result (tid-1789)
|
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1797)
|
Please review @nvazquez @DaanHoogland @borisstoyanov @rafaelweingartner and others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, additional public nics take the setting from the network offering, default offering is using the global settings. Router migration, static natting a separate VLAN is also working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not into this part of the code that much, but looking at the code I'm not able to find any blockers
Thanks for confirming @borisstoyanov and @wido for the review. |
Merging this based on regression tests, code reviews and two LGTMs. |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1451 |
Per the following doc, VR's guest/public nic should pick up network
rate from its network offering:
http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling
@blueorangutan package