Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-10233: use namespace in Libvirt domain metadata. #2410

Merged
merged 1 commit into from Jan 19, 2018

Conversation

fmaximus
Copy link
Contributor

The documentation of Libvirt specifies the requirement of using an XML namespace,
when having metadata in the Domain XML. The Nuage extenstion metadata was not
adhering to this specification, and the lastest Libvirt version ignores it in that case.

The documentation of Libvirt specifies the requirement of using an XML namespace,
when having metadata in the Domain XML. The Nuage extenstion metadata was not
adhering to this specification, and the lastest Libvirt version ignores it in that case.
@fmaximus fmaximus added this to the 4.11.1 milestone Jan 17, 2018
Copy link
Contributor

@krissterckx krissterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proved to work fine with the specified libvirt version.

LGTM

Copy link
Contributor

@smeetsr smeetsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified on top of RHEL7.2 & RHEL7.4

Copy link
Contributor

@sgoeminn sgoeminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krissterckx
Copy link
Contributor

@rhtyd as exchanged, for inclusion into 4.11.0.0 if there would be a 2nd RC. Thanks!

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

3 similar comments
@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1659

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2169)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24160 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2410-t2169-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Jan 19, 2018

Test LGTM, merging based on test results and code reviews.

This PR has been accepted towards 4.11.0.0, and should make into RC2 as it fixes a libvirt domain/vm xml spec issue and may cause issue when users are using nuage integration.

@rohityadavcloud rohityadavcloud merged commit cfff78d into apache:4.11 Jan 19, 2018
marcaurele pushed a commit to marcaurele/cloudstack that referenced this pull request Jan 23, 2018
)

The documentation of Libvirt specifies the requirement of using an XML namespace,
when having metadata in the Domain XML. The Nuage extenstion metadata was not
adhering to this specification, and the lastest Libvirt version ignores it in that case.
@rohityadavcloud rohityadavcloud modified the milestones: 4.11.1, 4.11.0 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants