[CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelweingartner
force-pushed
the
CLOUDSTACK-10329
branch
from
f3577cc
to
f4f6dbc
Compare
| }; | ||
| var createSafeCsvValue = function(value){ | ||
| if(value){ | ||
| return '"' + value + '"'; |
There was a problem hiding this comment.
Hi @rafaelweingartner, Thanks for adding this functionality.
Here, Will the input look like this: ("a","b","c"...) or (a,b,c...). The variable csv in generateCsvForAclRules function converts to string when it is initialized (concatenated with a comma string).
There was a problem hiding this comment.
@nitin-maharana thanks for the review, but I did not quite understand your question.
Here is an example of CSV generated using the code of this PR:
"id","#Rule","CIDR","Action","Protocol","#Protocol","Start Port","End Port","ICMP Type","ICMP Code","Traffic Type","Reason"
"ef06c57e-dc8b-40d9-a461-5a30072384ab","2","19.168.56.0/12","Allow","all",,,,,,"Ingress",
"45835dfb-260c-461d-8051-444ac764151e","102","19.168.56.0/12","Allow","tcp",,"1","1",,,"Ingress",
I am using this createSafeCsvValue to enclose the value with double quotes, which will avoid problems with values that may have commas in them. If you open the file generated with this code in Excel, it is transparent for users.
|
Code LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new button in ACS UI to export ACL rules in a CSV file. This is useful for reporting ACL rules configured.
The following picture is a screenshot.
