systemvm: baremetal-vr: reduce memory usage

[resmo]

Description

We see a suspicious continuous increase in memory usage. Kind of looks like a memory leak.

One thing noted during debugging is that flask is started in debug mode. This is not best practice for a production system.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2323

[rohityadavcloud]

@blueorangutan test

[borisstoyanov]

@resmo have you run any tests on baremetal setup? I'm curious if that could cause any regression.

[resmo]

@borisstoyanov no, however, it is going to be started here https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/setup/postinit.sh#L63 not limited to bare metal afaics

[borisstoyanov]

thanks @resmo
@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3050)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25081 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2866-t3050-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1142.14	test_privategw_acl.py
test_05_rvpc_multi_tiers	Failure	320.81	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	342.87	test_vpc_redundant.py

[borisstoyanov]

LGTM