New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: update dhcp configurations in vrs while update default nic of running vms #3205
server: update dhcp configurations in vrs while update default nic of running vms #3205
Conversation
… running vms In virtual routers, there are different dnsmasq settings for default nic and non-default nic on vm. We need to update dhcp informations on network vrs when default nic is changed. For example, if 172.16.1.135 is non-default nic of vm VPC1-001-001, then root@r-22-VM:~# cat /etc/dhcphosts.txt 02:00:1d:15:00:05,set:172_16_1_135,172.16.1.135,VPC1-001-001,710h root@r-22-VM:~# cat /etc/dhcpopts.txt 172_16_1_135,3 172_16_1_135,6 172_16_1_135,15 If it is default nic,then root@r-22-VM:~# cat /etc/dhcpopts.txt root@r-22-VM:~# cat /etc/dhcphosts.txt 02:00:1d:15:00:05,172.16.1.135,VPC1-001-001,757h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding comment.
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2793 |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-3609)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on code.
In virtual routers, there are different dnsmasq settings for default nic and non-default nic on vm.
We need to update dhcp informations on network vrs when default nic is changed.
For example, if 172.16.1.135 is non-default nic of vm VPC1-001-001, then
root@r-22-VM:
# cat /etc/dhcphosts.txt# cat /etc/dhcpopts.txt02:00:1d:15:00:05,set:172_16_1_135,172.16.1.135,VPC1-001-001,710h
root@r-22-VM:
172_16_1_135,3
172_16_1_135,6
172_16_1_135,15
If it is default nic,then
root@r-22-VM:
# cat /etc/dhcpopts.txt# cat /etc/dhcphosts.txtroot@r-22-VM:
02:00:1d:15:00:05,172.16.1.135,VPC1-001-001,757h
Fixes: #3201
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?