Change tests random number generator to /dev/urandom #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a big performance issue with random number generation with more recent kernels and java versions in linux
| @@ -958,6 +958,9 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>2.18.1</version> | |||
| <configuration> | |||
| <argLine>-Djava.security.egd=file:/dev/./urandom</argLine> | |||
There was a problem hiding this comment.
why not simply, "/dev/urandom" ?
|
there's a builtin symlink that redirects /dev/urandom to /dev/random. this is the only way to make it work :) |
|
It was on my todo list for a long long time to check the random times of tests. |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2015
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
UI changes for #4103 Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a big performance issue with random number generation with more recent kernels and java versions in linux, the impact is specially higher on VMs
Some tests (that use random number generation) in some environments take randomly 1 - 20 mins to perform tests that should take only seconds to run.
This PR is just intended for fixing it on the tests.