Build css from scss sources in client ui build #3433
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following things are done in this PR:
Add the compiling of the scss sources to css to the maven build for the client ui. I used this (https://github.com/eirslett/frontend-maven-plugin) maven plugin for that.
This was required to remove the css files from the project. This is necessary, because it happened multiple times that the css files were modified directly instead of editing and then compiling the scss files, which results in a mismatch between the scss src and the compiled css.
e.g. https://github.com/apache/cloudstack/pull/3240/files
I also moved the ui folder with the frontend resources inside the client ui module folder because they got only used there and it is a better location for them.
This (compiling scss to css during the build) is the currently preferred way of handling these frontend resources.
This changes are not affecting any functionality nor are a breaking change.
Types of changes
How Has This Been Tested?
Deployed this to our test environment and tested functionality.