Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build css from scss sources in client ui build #3433

Closed

Conversation

pbankonier
Copy link
Contributor

Description

The following things are done in this PR:

  • Add the compiling of the scss sources to css to the maven build for the client ui. I used this (https://github.com/eirslett/frontend-maven-plugin) maven plugin for that.

  • This was required to remove the css files from the project. This is necessary, because it happened multiple times that the css files were modified directly instead of editing and then compiling the scss files, which results in a mismatch between the scss src and the compiled css.
    e.g. https://github.com/apache/cloudstack/pull/3240/files

  • I also moved the ui folder with the frontend resources inside the client ui module folder because they got only used there and it is a better location for them.

  • This (compiling scss to css during the build) is the currently preferred way of handling these frontend resources.

  • This changes are not affecting any functionality nor are a breaking change.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Deployed this to our test environment and tested functionality.

@pbankonier pbankonier closed this Jun 27, 2019
@pbankonier pbankonier deleted the feature_scss_client_ui_build branch June 27, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant