Fix VR bootstrapping/connection state in KVM

[svenvogel]

Description

• After PR systemvm: new qemu-guest-agent based patching for KVM #3278 there was some changes on the channels. this does not seem like the problem. if we look to the VR XML file we see the following. the qemu guest agent must be the problem because the state of the VR is "disconnected".

   <channel type='unix'>
     <source mode='bind' path='/var/lib/libvirt/qemu/r-1750-VM.org.qemu.guest_agent.0'/>
     <target type='virtio' name='org.qemu.guest_agent.0' state='disconnected'/>
     <alias name='channel0'/>
     <address type='virtio-serial' controller='0' bus='0' port='1'/>
   </channel>

after investigation of the bootstrap process i think i found this problem. there is no startup from the qemu-guest-agent. we need them in connected state for the patch.sh script.

the problems seems to be the startup of the "qemu-guest-agent". since this is not an really systemd service more than an sysvinit. the service will be started with "systemctl enable --now qemu-guest agent". this will be redirected to systemd-sysv-install. normally "--now" should enable and start the service. i think with this redirection to systemd-sysv-install there is no option for the startup.

• last one is to capture the error from the module load kvm pci hotplug

Use actually master, build a SystemVM and try to deploy them

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[rohityadavcloud]

Minor nit: The --now does the same, enables and starts it.

[svenvogel]

@rhtyd yes normally it should but qemu-guest-agent it a sysvinit and unfortunately with this redirect there is no startup.

[root@kvm08 /]# /lib/systemd/systemd-sysv-install --help
systemd-sysv-install version 1.7.4 - Copyright (C) 1997-2000 Red Hat, Inc.
This may be freely redistributed under the terms of the GNU Public License.

usage:   systemd-sysv-install <enable|disable|is-enabled> [name]

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[rohityadavcloud]

@svenvogel is this work in progress or ready for review?

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-188

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[svenvogel]

@rhtyd yes its ready. there is nothing from me. :)

[blueorangutan]

Trillian test result (tid-228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41063 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3524-t228-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	971.62	test_privategw_acl.py
test_hostha_enable_ha_when_host_in_maintenance	Error	304.77	test_hostha_kvm.py

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rohityadavcloud]

Tests lgtm. Can you review @shwstppr @anuragaw @borisstoyanov

[blueorangutan]

Trillian test result (tid-232)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30143 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3524-t232-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Error	201.78	test_internal_lb.py

[rohityadavcloud]

Tests LGTM

[shwstppr]

LGTM based on changes and Travis results