You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploying a VM via UI, networks that have all the following characteristics are not listed on the wizard:
advanced networking with security groups
traffic type of "Guest"
guest type of "Shared"
IPv6 CIDR not null
This PR fixes it by removing the verification that counts the IPs from UserIpv6AddressVO in order to check if it can use the network for deploying new VMs in UI [1]. Table "user_ipv6_address" (UserIpv6AddressVO) is empty and will always be as it is a legacy code/table, not used in any IP
allocation flow. Therefore, the removed verification should be removed.
The Javascript code adds the parameter canusefordeploy=true on the API call when the network is an advanced network with security groups. With that, the endpoint (management server) expects "canUseForDeploy" to be true; however, the returned value is false due to not finding IPv6 addresses available in the network, which makes the UI to not list those networks.
#3569 IPv6 code cleanup: several PRs will be created in the near future aiming a complete cleanup on IPv6 code in order to avoid such mistakes to repeat
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases
is not used; probably it is a legacy code/table.
Therefore, remove the verification that counts the IPs from
UserIpv6AddressVO in order to check if it can use the network for
deploying new VMs in UI [1].
[1] com.cloud.network.NetworkModelImpl.canUseForDeploy(Network).
Trillian test result (tid-343)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3571-t343-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deploying a VM via UI, networks that have all the following characteristics are not listed on the wizard:
This PR fixes it by removing the verification that counts the IPs from UserIpv6AddressVO in order to check if it can use the network for deploying new VMs in UI [1]. Table "user_ipv6_address" (UserIpv6AddressVO) is empty and will always be as it is a legacy code/table, not used in any IP
allocation flow. Therefore, the removed verification should be removed.
[1] com.cloud.network.NetworkModelImpl.canUseForDeploy(Network)
This PR fixes #3570
Why it happens
The Javascript code adds the parameter
canusefordeploy=trueon the API call when the network is an advanced network with security groups. With that, the endpoint (management server) expects "canUseForDeploy" to be true; however, the returned value is false due to not finding IPv6 addresses available in the network, which makes the UI to not list those networks.#3569 IPv6 code cleanup: several PRs will be created in the near future aiming a complete cleanup on IPv6 code in order to avoid such mistakes to repeat
Types of changes