vpc: add bypassvlanoverlapcheck parameter when create private gateway

[ustcweizhou]

Description

The vlan of private gateways in VPCs should not be same. In some edge cases, vlan of private gateways are same (for example in test_privategw_acl.py).

Similar as shared network, add bypassvlanoverlapcheck parameter when create private gateway.

This also fixes #3859 .
the root cause is #3859 (comment)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Run test_privategw_acl.py several times, no failure any more.

[ustcweizhou]

@rhtyd this is the fix for trillian test

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-923

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1069)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28691 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3899-t1069-kvm-centos7.zip
Smoke tests completed. 80 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[rohityadavcloud]

@DaanHoogland @andrijapanicsb cc @PaulAngus @borisstoyanov @nvazquez - need more eye to ensure this does not cause any regression
@blueorangutan test centos7 vmware-65u2

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1077)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30030 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3899-t1077-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@blueorangutan test centos7 xenserver-71

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1081)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30244 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3899-t1081-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 79 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	Failure	18.52	test_scale_vm.py

[DaanHoogland]

this is a lot of code change for a little functional change, what I've seen so far looks good, but I do want to take an hour or so later to go through it line by line. If others test extensively that fina as well, by me.
(@rhtyd @weizhouapache @andrijapanicsb)

[weizhouapache]

this is a lot of code change for a little functional change, what I've seen so far looks good, but I do want to take an hour or so later to go through it line by line. If others test extensively that fina as well, by me.
(@rhtyd @weizhouapache @andrijapanicsb)

@DaanHoogland
there are actually two main changes which are not independent.
(1) add vpcid in method getPrivateNetwork.
(2) add bypassvlanoverlapcheck parameter when create private gateway

in test_privategw_acl.py, it tests the vm connectivity between two VPCs. The two VPCs connect each time by private gateways. The two private gateways have same cidr/vlan, but different gateway (gateway of private gateway in a VPC is the ip attached on another VPC).
in method getPrivateNetwork, the private gateways with same cidr/vlan are mapped to the same isolated network, so one of them has wrong gateway. That's why many trillian test failed.

Therefore I add vpcid to method getPrivateNetwork so they are mapped to different network (with correct gateway). It has another issue that they use same vlan, so I have to add bypassvlanoverlapcheck parameter.

[DaanHoogland]

code lgtm