New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix issue while list ssh keypairs by keyword #3916
server: fix issue while list ssh keypairs by keyword #3916
Conversation
in 4.13, list sshkeypairs with keyword will ignore the search by name if name is specifed for example, (local) > list sshkeypairs name=wei keyword=wei filter=name { "count": 3, "sshkeypair": [ { "name": "wei3" }, { "name": "wei2" }, { "name": "wei" } ] } with this patch ,it gives correct result. (local) > list sshkeypairs name=wei keyword=wei filter=name { "count": 1, "sshkeypair": [ { "name": "wei" } ] }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, did not test it
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-949 |
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1118)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on code changes, given API results
Description
in 4.13, list sshkeypairs with keyword will ignore the search by name if name is specifed.
Fixes an issue in #3098
for example,
with this patch ,it gives correct result.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?