New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPE fix for System VM's start Command #3985
NPE fix for System VM's start Command #3985
Conversation
...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
Outdated
Show resolved
Hide resolved
2a5a68c
to
e213cea
Compare
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on VMware, Systemvms are coming up normally. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, in spite of the twice used constant.
could have been
private static final VMWARE_BOOT_MODE = ApiConstants.BootType.BIOS.toString();
@blueorangutan test matrix |
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
Trillian test result (tid-1292)
|
Trillian test result (tid-1291)
|
Trillian test result (tid-1293)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
@pavanaravapalli please review #4088/#4089 |
This reverts commit 08699aa.
Description
System VM's are failed to deploy on VM ware setup, due to NPE.
Solution : Added Null check for the same and took care of respective code flow changes.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Yet to test and update.