kvm: qemu-img convert -s to backup snapshot is deprecated #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the qemu-img convert command to use the support way to create qcow2 file from a snapshot name of a qcow2 volume using the `-l snapshot.name=<name>` as the `-s <snapshot name` is no longer supported in newer qemu-img. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
rohityadavcloud
requested review from
andrijapanicsb,
DaanHoogland,
GabrielBrascher,
weizhouapache and
wido
rohityadavcloud
commented
May 20, 2020
| @@ -153,7 +153,7 @@ destroy_snapshot() { | |||
| lvm lvremove -f "${vg}/${snapshotname}-cow" | |||
| elif [ -f $disk ]; then | |||
| #delete all the existing snapshots | |||
| $qemu_img snapshot -l $disk |tail -n +3|awk '{print $1}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2 | |||
| $qemu_img snapshot -l $disk |tail -n +3|awk '{print $2}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2 | |||
There was a problem hiding this comment.
@shwstppr @davidjumani can any of you advise if qemu-img snapshot -l second column is the name of the snapshot or ID? qemu-img snapshot -d in Ubuntu 20.04 and possibly CentOS8 only accepts snapshot name and not the ID.
There was a problem hiding this comment.
@rhtyd from the qemu wiki :
$ qemu-img snapshot -l xxtest.qcow2
Snapshot list:
ID TAG VM SIZE DATE VM CLOCK
1 1.5M 2010-07-26 16:51:52 00:00:08.599
2 1.5M 2010-07-26 16:51:53 00:00:09.719
3 1.5M 2010-07-26 17:26:49 00:00:13.245
4 1.5M 2010-07-26 19:01:00 00:00:46.763
no name to be found.
There was a problem hiding this comment.
@DaanHoogland I think we'll have to check the command for our snapshots, when we create them we generally pass like a uuid-looking name. @shwstppr @davidjumani can you test and confirm (with centos7 vs centos8) with this PR?
|
Packaging result: ✔centos7 ✔debian. JID-1237 |
|
@blueorangutan test |
1 similar comment
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1555)
|
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1556)
|
5 tasks
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔debian. JID-1243 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1566)
|
|
Looks like this change breaks snapshot for older/centos7 distro :( |
|
ping @shwstppr @davidjumani - let me know if this issue has been handled in the other PR (centos8 or ubuntu 20.04)? I'll close this PR. |
|
@rhtyd Checked with CentOS8. This PR branch over #4068. No regression in snapshot behavior.
|
|
Keep in mind that the code for volume snapshot while VM is running (kvm.snapshot.enabled=true) vs when VM is stopped is completely different code path - i.e. should be tested. |
|
@andrijapanicsb will check and report after changing that setting cc @rhtyd |
|
After setting to true,
|
|
I'll close this, please refer this PR and port changes to #4068 instead @shwstppr @davidjumani Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the qemu-img convert command to use the support way to create
qcow2 file from a snapshot name of a qcow2 volume using the
-l snapshot.name=<name>as the-s <snapshot nameis no longer supportedin newer qemu-img.
Tested on Ubuntu 20.04, needs testing on CentOS8 cc @davidjumani @shwstppr and regression testing on CentOS7 and Ubuntu 16.04/18.04 cc @wido @GabrielBrascher
Types of changes