Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvm: bump jna version to latest #4119

Merged
merged 1 commit into from Jun 8, 2020
Merged

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented May 29, 2020

This fixes issue for cloudstack-agent to make connections to libvirt
on arm64 boards.

The jna-platform provides non-default (x86_64) mappings, read more:
https://github.com/java-native-access/jna/blob/master/www/PlatformLibrary.md

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This fixes issue for cloudstack-agent to make connections to libvirt
on arm64 boards.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1257

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1591)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54149 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4119-t1591-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_deploy_kubernetes_ha_cluster Error 3621.19 test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster Error 0.05 test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster Error 0.05 test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster Error 0.05 test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster Error 0.05 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 61.85 test_kubernetes_clusters.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan test ubuntu kvm-ubuntu

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos7 ✖debian. JID-1274

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem in the PR but BO failed to build and we are adding a new lib. Can you add a line on why and what it gives us, @rhtyd? I.E., how it fixes the connections?

Copy link
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud
Copy link
Member Author

@DaanHoogland thanks I've updated the description, the addition of jna-platform allows the cloudstack-agent to run on arm64 (RaspberryPi) boards. Without this dependency, cloudstack-agent may not work on certain platforms/CPUs.

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1296

@rohityadavcloud
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1627)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4119-t1627-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@rohityadavcloud rohityadavcloud merged commit 5a557f3 into apache:master Jun 8, 2020
@rohityadavcloud rohityadavcloud deleted the jna-fix branch June 8, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants