server: don't export B&R APIs if feature is not enabled globally

[rohityadavcloud]

This change will ensure that B&R APIs are not exported if the feature is not enabled globally. Make it non-dynamic to require restarting of mgmt server which is needed for the background sync task to be setup or not.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1534

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1994)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 7573 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4202-t1994-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_backup_recovery_dummy.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 28 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDummyBackupAndRecovery>:setup	Error	0.00	test_backup_recovery_dummy.py

[GabrielBrascher]

Thanks for the PR @rhtyd, code LGTM.

I just left a minor remark; could you please check if the raised question makes sense?

[GabrielBrascher]

According to the description, ADMIN needs to restart the management server and therefore this is not a dynamic setting.

What do you think of changing the isDynamic param to false?

ConfigKey constructor:

public ConfigKey(String category, Class<T> type, String name, String defaultValue, String description, boolean isDynamic, Scope scope) {
    this(type, name, category, defaultValue, description, isDynamic, scope, null);
}

[rohityadavcloud]

I'll change that.

[rohityadavcloud]

Fixed thanks

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1536

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rohityadavcloud]

@davidjumani please review this, thnx

[blueorangutan]

Trillian test result (tid-2008)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49880 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4202-t2008-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_backup_recovery_dummy.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDummyBackupAndRecovery>:setup	Error	0.00	test_backup_recovery_dummy.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Error	470.84	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Error	3853.05	test_vpc_redundant.py

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1539

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1547

[Pearl1594]

LGTM. Test passes for simulator

[rohityadavcloud]

Tested on KVM env, it skips tests for dummy provider now:

Import provider backup offering from Dummy Backup and Recovery Provider ... SKIP: Skipping test cases which must only run for Simulator
Test VM backup lifecycle ... SKIP: Skipping test cases which must only run for Simulator

----------------------------------------------------------------------
Ran 2 tests in 0.124s

OK (SKIP=2)