Removed check on SSLEngine client mode

[Spaceman1984]

Description

The SSL engine defaults to "Server mode" when doing handshaking. This PR removes the check on the mode which was causing tests to fail.

This behavior was changed in OpenJDK 11.0.8

JDK-8245077: Default SSLEngine Created in Server Role
=====================================================
In JDK 11 and later, `javax.net.ssl.SSLEngine` by default used client
mode when handshaking.  As a result, the set of default enabled
protocols may differ to what is expected. `SSLEngine` would usually be
used in server mode. From this JDK release onwards, `SSLEngine` will
default to server mode. The
`javax.net.ssl.SSLEngine.setUseClientMode(boolean mode)` method may be
used to configure the mode.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This was tested by building Cloudstack and allowing the tests to run.

[Spaceman1984]

@blueorangutan package

[blueorangutan]

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1610

[Spaceman1984]

@blueorangutan test

[blueorangutan]

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2206)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4222-t2206-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	260.69	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	235.44	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	983.67	test_privategw_acl.py
ContextSuite context=Test01DeployVM>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	Error	0.00	test_vm_life_cycle.py

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2207)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29112 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4222-t2207-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	180.10	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	175.19	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	247.24	test_privategw_acl.py
ContextSuite context=Test01DeployVM>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	Error	0.00	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	Error	0.00	test_vm_life_cycle.py

[GabrielBrascher]

I had some issues on master, where the test checks for true Assert.assertTrue(e.getUseClientMode()); , not assertFalse. will this be forwarded to master as well?

[Spaceman1984]

I had some issues on master, where the test checks for true Assert.assertTrue(e.getUseClientMode()); , not assertFalse. will this be forwarded to master as well?

@GabrielBrascher , I will create a pull request for master.

[GabrielBrascher]

PR closed in favor of #4226