Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vSphere advanced capabilities with datastore support and api improvements #4248

Closed
wants to merge 77 commits into from
Closed

vSphere advanced capabilities with datastore support and api improvements #4248

wants to merge 77 commits into from

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Aug 6, 2020 •
edited by rohityadavcloud

Description

Added support for different datastore types like vSAN, vVols, VMFS6, Datastore clusters. Along with these native APIs of vCenter have been used.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1667

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

@harikrishna-patnala most of the tests are failing for travis/simulator hinting at general failures - can you have a look at simulator failures and manually test vm lifecycle before pushing trillian to work (which takes hours)?

@rohityadavcloud rohityadavcloud added the Severity:Critical Critical bug label Aug 7, 2020
@rohityadavcloud rohityadavcloud added this to the 4.15.0.0 milestone Aug 7, 2020
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@harikrishna-patnala
Copy link
Contributor Author

Sure @rhtyd I'll check simulator failures

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1671

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Aug 7, 2020 •
edited

@harikrishna-patnala when deploying zone (with simulator) this fails with:

Exception Occurred: ['Traceback (most recent call last):\n', '  File "tools/marvin/marvin/deployDataCenter.py", line 280, in createPrimaryStorages\n    ret = self.__apiClient.createStoragePool(primarycmd)\n', '  File "/usr/local/lib/python2.7/dist-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 3364, in createStoragePool\n    response = self.connection.marvinRequest(command, response_type=response, method=method)\n', '  File "/usr/local/lib/python2.7/dist-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest\n    raise e\n', 'CloudstackAPIException: Execute cmd: createstoragepool failed, due to: errorCode: 530, errorText:Failed to add data store: Failed to access storage pool\n']

2020-08-07 14:01:28,340 WARN  [o.a.c.s.d.l.CloudStackPrimaryDataStoreLifeCycleImpl] (ApiServer-8:ctx-c2e3faa6 ctx-b78205c4) (logid:163a78d3) Unable to establish a connection between Host[-2-Routing] and org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl@19656adf
java.lang.NullPointerException
	at org.apache.cloudstack.storage.datastore.provider.DefaultHostListener.hostConnect(DefaultHostListener.java:106)
	at com.cloud.storage.StorageManagerImpl.connectHostToSharedPool(StorageManagerImpl.java:1027)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUs

@rohityadavcloud
Copy link
Member

@blueorangutan test matrix

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Aug 9, 2020
@apache apache deleted a comment from blueorangutan Aug 9, 2020
@blueorangutan
Copy link

Packaging result: ✖centos7 ✔debian. JID-1683

@rohityadavcloud
Copy link
Member

re-kicked centos7 pkg manually

@harikrishna-patnala
Copy link
Contributor Author

re-kicked centos7 pkg manually

Thanks @rhtyd

@rohityadavcloud
Copy link
Member

@blueorangutan test matrix

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1686

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1832

@rohityadavcloud
Copy link
Member

@blueorangutan test matrix

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@davidjumani
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1858

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1895

@rohityadavcloud
Copy link
Member

@blueorangutan test matrix

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-2672)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2672-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 1807.09 test_kubernetes_supported_versions.py
test_01_scale_vm Failure 35.63 test_scale_vm.py

@blueorangutan
Copy link

Trillian test result (tid-2677)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2677-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 424.53 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 332.95 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3907.24 test_vpc_redundant.py
test_hostha_kvm_host_fencing Error 166.73 test_hostha_kvm.py

@nvazquez nvazquez mentioned this pull request Sep 7, 2020
Merged
5 tasks
@rohityadavcloud
Copy link
Member

@harikrishna-patnala can you review and close this PR and continue work over #4307 thnx

@blueorangutan
Copy link

Trillian test result (tid-2679)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54350 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2679-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_ping_in_ssvm_success Failure 14.41 test_diagnostics.py
test_05_ping_in_cpvm_success Failure 14.47 test_diagnostics.py
test_04_delete_domain_with_project Error 34.42 test_projects.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 384.57 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 317.91 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3894.39 test_vpc_redundant.py
test_hostha_kvm_host_fencing Error 173.87 test_hostha_kvm.py

@blueorangutan
Copy link

Trillian test result (tid-2678)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58981 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4248-t2678-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_deploy_kubernetes_cluster Error 0.21 test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster Error 0.10 test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster Error 0.16 test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster Error 0.18 test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster Error 0.24 test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster Error 0.25 test_kubernetes_clusters.py
test_oobm_issue_power_cycle Error 24.50 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 30.78 test_outofbandmanagement.py
test_02_list_snapshots_with_removed_data_store Error 103.24 test_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 702.80 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3965.36 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3965.46 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 0.07 test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown Error 0.13 test_vpc_redundant.py

@harikrishna-patnala
Copy link
Contributor Author

Closing this PR as this is merged with another feature on PR #4307

@mib1185 mib1185 mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@andrijapanicsb andrijapanicsb Awaiting requested review from andrijapanicsb

@nvazquez nvazquez Awaiting requested review from nvazquez

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees
No one assigned
Labels
component:vmware Severity:Critical Critical bug
Projects
None yet
Milestone
4.15.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@harikrishna-patnala @blueorangutan @rohityadavcloud @borisstoyanov @davidjumani @DaanHoogland