Avoid Null pointer at DomainChecker and enhance AssignVMCmd #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd not valid projectID
GabrielBrascher
force-pushed
the
null-at-domainchecker
branch
from
a3973be
to
cc8068c
Compare
GabrielBrascher
force-pushed
the
null-at-domainchecker
branch
from
cc8068c
to
f74dbdb
Compare
rohityadavcloud
requested changes
Aug 23, 2020
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java
Outdated
Show resolved
Hide resolved
GabrielBrascher
force-pushed
the
null-at-domainchecker
branch
from
29a65eb
to
0ca3546
Compare
|
@blueorangutan package |
rohityadavcloud
approved these changes
Aug 25, 2020
rohityadavcloud
approved these changes
Aug 25, 2020
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1817 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1819 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1836 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Test manually rekicked |
|
LGTM merging this based on Travis tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When executing request assignVirtualMachine with null
domainIDand a validprojectIDthen aNullPointerExceptionhappens at DomainChecker.java.Command example:
The
NullPointerExceptionthat is thrown atDomainCheckeris handled at AssignVMCmd.java#L142, resulting in the following log message:Failed to move vm null.My question is: does it make sense to assign VM to a project with
domainID=null? If so, then the handling should be different. However, I think that it should not benulland therefore I added a proper log message.Prior to commit
Types of changes
How Has This Been Tested?
Request of API command assignVirtualMachine with project ID and
nulldomainID.