Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallowing udp for lb rules for haproxy #4501

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Disallowing udp for lb rules for haproxy #4501

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5f4301
Disallowing udp for lb rules
davidjumani Nov 24, 2020
e23537b
Revert "Disallowing udp for lb rules"
davidjumani Nov 26, 2020
9fee66d
Adding check for udp rules for haproxy
davidjumani Nov 26, 2020
7227685
Adding defensive check
davidjumani Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,13 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
return false;
}
String lbProtocol = rule.getLbProtocol().toLowerCase();
if (lbProtocol.equals(NetUtils.UDP_PROTO)) {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Can't create LB rule as haproxy does not support udp");
}
return false;
}

for (final LoadBalancingRule.LbStickinessPolicy stickinessPolicy : rule.getStickinessPolicies()) {
final List<Pair<String, String>> paramsList = stickinessPolicy.getParams();
Expand Down