db: Fix description of volume.stats.interval which is in milliseconds… #4526
Conversation
|
@ustcweizhou this was already addressed in PR #3415. Which CS version you see the wrong description? |
@sureshanaparti I have some 4.14 and 4.15 env, all have the issue. |
There was a problem hiding this comment.
I'm fine with this #3415 only fixes this if the value is not yet in the configs table / for newly created. This updates existing rows in the DB
@DaanHoogland all my testing env are installed from scratch, and they have same issue. How about it on your testing env ? |
|
@weizhouapache I hadn't looked at this particular issue yet. I'll have a look in a recent env. |
|
@weizhouapache yes you are right! 😮 looks like #3415 wasn't tested. |
|
did a quick search and it is hardcoded in schema-41000to41100.sql so the auto-adding value did not get considered. |
|
I'll await the travis output and merge |
yeah. should we fix it in 4.14 branch as well ? it is LTS. |
|
@weizhouapache you can change base branch |
yes, I could see this issue with fresh 4.15 setup. this change is good to go. |
* master: server: add conditions for custom offerings (apache#4540) vr: Ensuring dnsmasq.leases file is populated (apache#4529) template: Ensuring template is cross zone if type changed to system (apache#4522) storage: Fix hypervisor type cast to string (apache#4516) db upgrade: fix sql exception: Access denied; you need (at least one of) the SUPER privilege(s) for this operation (apache#4533) CLOUDSTACK-10423:Potential sensitive information disclosure (apache#4536) jobs: The patch remove the password from resultObject and make it be humanreadable (apache#4538) listphysicalnetworks: Honouring keyword parameter (apache#4511) Fix NPE when Volume exists on secondary store but doesn't have a download URL (apache#4530) apidoc issue (apache#4532) db: Fix description of volume.stats.interval which is in milliseconds not seconds (apache#4526) kvm: set cpu topology only if cpucore per socket is positive value (apache#4527) xenserver: check and eject patch vbd for systemvms (apache#4525) Fix warning when setup cloudstack-common (apache#4523) kvm: FIX cpucorespersocket is not working on KVM (apache#4497) change debug to warn for unknown exceptions (apache#4521) Fix failure in validating IP address in case of multiple Management Servers (apache#4507) Update log output for FirstFitPlanner (apache#4515) ui: deprecate old UI and move to legacy to be served at /client/legacy (apache#4518)
Description
This PR fixes description of volume.stats.interval which is in milliseconds, but not in seconds.
see screenshot below
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?