vpc: dnsmasq is not started if use.external.dns is true #4806

ustcweizhou · 2021-03-12T14:17:50Z

Description

This PR fixes the issue that dnsmasq cannot be started in VPC VR is use.external.dns is true

Steps to reproduce the issue
(1) change global setting use.external.dns to true
(2) create vpc
(3) create vpc tier and a vm
(4) restart VPC VR, or restart VPC with cleanup
(5) check VPC VR, dnasmasq is not started with error

Mar 12 14:15:07 r-999-VM dnsmasq[11176]: dnsmasq: bad IP address at line 5 of /etc/dnsmasq.d/cloud.conf
Mar 12 14:15:07 r-999-VM dnsmasq[11176]: bad IP address at line 5 of /etc/dnsmasq.d/cloud.conf
Mar 12 14:15:07 r-999-VM dnsmasq[11176]: FAILED to start up

dnsmasq config

root@r-999-VM:~# cat /etc/dnsmasq.d/cloud.conf
dhcp-hostsfile=/etc/dhcphosts.txt
listen-address=127.0.0.1,192.168.20.1
dhcp-range=set:interface-eth2-0,192.168.20.1,static
dhcp-option=tag:interface-eth2-0,15,cs2cloud.internal
dhcp-option=tag:interface-eth2-0,6,
dhcp-option=tag:interface-eth2-0,3,192.168.20.1
dhcp-option=tag:interface-eth2-0,1,255.255.255.240

with this PR, dnsmasq config is good and dnsmasq is running

root@r-999-VM:~# cat /etc/dnsmasq.d/cloud.conf
dhcp-hostsfile=/etc/dhcphosts.txt
listen-address=127.0.0.1,192.168.20.1
dhcp-range=set:interface-eth2-0,192.168.20.1,static
dhcp-option=tag:interface-eth2-0,15,cs2cloud.internal
dhcp-option=tag:interface-eth2-0,6,8.8.8.8
dhcp-option=tag:interface-eth2-0,3,192.168.20.1
dhcp-option=tag:interface-eth2-0,1,255.255.255.240

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

davidjumani · 2021-03-15T05:54:04Z

@blueorangutan package

blueorangutan · 2021-03-15T05:55:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T06:24:17Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 111

davidjumani · 2021-03-15T07:16:52Z

@weizhouapache I'm unable to reproduce the issue
dnsmasq comes up fine
Is there anything that was missed?

Set use.external.dns = true
Created a VPC
Created a tier
Brought up a VM
Checked dnsmasq status and config

use.external.dns = false

use.external.dns = true

davidjumani · 2021-03-15T07:21:03Z

@blueorangutan package

blueorangutan · 2021-03-15T07:22:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

weizhouapache · 2021-03-15T07:41:50Z

@weizhouapache I'm unable to reproduce the issue
dnsmasq comes up fine
Is there anything that was missed?

Set use.external.dns = true

Created a VPC

Created a tier

Brought up a VM

Checked dnsmasq status and config

use.external.dns = false

use.external.dns = true

@davidjumani can you share the content of /etc/cloudstack/guestnetwork.json in VR ?

blueorangutan · 2021-03-15T08:01:58Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 114

davidjumani · 2021-03-15T08:14:06Z

@weizhouapache This is when use.external.dns = false

use.external.dns = true

weizhouapache · 2021-03-15T08:41:32Z

@weizhouapache This is when use.external.dns = false

use.external.dns = true

@davidjumani thanks.
'dns' is missing in my testing, strange. It might be caused by different vpc network offerings. I will check .

weizhouapache · 2021-03-15T11:46:12Z

@weizhouapache This is when use.external.dns = false

use.external.dns = true

@davidjumani thanks.
'dns' is missing in my testing, strange. It might be caused by different vpc network offerings. I will check .

@davidjumani could you please restart the vpc vr and check again ?

This reverts commit ee58fe0.

…rt vpc or vpc VR

blueorangutan · 2021-03-15T17:13:07Z

Packaging result: ✖️ centos7 ✖️ centos8 ✔️ debian. SL-JID 125

davidjumani · 2021-03-16T05:19:52Z

@blueorangutan package

blueorangutan · 2021-03-16T05:23:37Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T05:58:22Z

Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 129

davidjumani · 2021-03-16T06:01:09Z

@blueorangutan package

blueorangutan · 2021-03-16T06:03:20Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T06:28:45Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 132

davidjumani · 2021-03-16T08:19:41Z

@weizhouapache Was able to reporduce the error when rebooting the router, fixed with this change!

rohityadavcloud · 2021-03-17T12:04:35Z

@blueorangutan test

blueorangutan · 2021-03-17T12:05:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]

blueorangutan · 2021-03-18T16:56:44Z

[S] Trillian test result (tid-147)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 102197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4806-t147-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 26 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_lb_rule_src_nat	`Failure`	307.22	test_loadbalance.py
test_02_create_lb_rule_non_nat	`Failure`	34.55	test_loadbalance.py
test_assign_and_removal_lb	`Failure`	34.55	test_loadbalance.py
test_01_verify_libvirt	`Error`	602.64	test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart	`Error`	610.05	test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk	`Error`	605.89	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	`Error`	602.17	test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart	`Error`	610.10	test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again	`Error`	602.06	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestAddConfigtoDeployVM>:setup	`Error`	0.00	test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_nat	`Failure`	605.04	test_network.py
test_02_port_fwd_on_non_src_nat	`Failure`	607.98	test_network.py
ContextSuite context=TestPrivateVlansL2Networks>:setup	`Error`	1230.29	test_network.py
test_reboot_router	`Failure`	358.49	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	`Error`	608.65	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	`Error`	609.06	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	`Error`	612.19	test_network.py
test_isolate_network_password_server	`Failure`	157.27	test_password_server.py
test_02_vpc_privategw_static_routes	`Failure`	757.99	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	756.25	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	845.70	test_privategw_acl.py
test_01_disableHumanReadableLogs	`Error`	602.80	test_human_readable_logs.py
test_02_enableHumanReadableLogs	`Error`	602.85	test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	270.49	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	320.62	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	137.60	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	176.74	test_internal_lb.py
test_01_deploy_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	0.01	test_kubernetes_supported_versions.py
test_router_dhcphosts	`Failure`	157.10	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown	`Error`	167.38	test_router_dhcphosts.py
test_router_dhcp_opts	`Error`	609.22	test_router_dhcphosts.py
test_router_dns_guestipquery	`Failure`	454.73	test_router_dns.py
test_router_dns_guestipquery	`Failure`	455.20	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	659.44	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	722.08	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	209.56	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Failure`	209.52	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	244.24	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Failure`	243.37	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	689.13	test_routers_network_ops.py
test_01_router_internal_basic	`Error`	602.82	test_routers.py
test_02_router_internal_adv	`Error`	602.76	test_routers.py
test_04_restart_network_wo_cleanup	`Error`	605.08	test_routers.py
test_01_service_offering_cpu_limit_use	`Error`	100.49	test_service_offerings.py
test_04_change_offering_small	`Failure`	714.76	test_service_offerings.py
test_01_snapshot_root_disk	`Error`	605.89	test_snapshots.py
test_03_ssvm_internals	`Error`	602.73	test_ssvm.py
test_04_cpvm_internals	`Error`	602.71	test_ssvm.py
test_05_stop_ssvm	`Error`	649.52	test_ssvm.py
test_06_stop_cpvm	`Error`	656.31	test_ssvm.py
test_07_reboot_ssvm	`Error`	717.10	test_ssvm.py
test_08_reboot_cpvm	`Error`	624.12	test_ssvm.py
test_09_destroy_ssvm	`Error`	671.31	test_ssvm.py
test_10_destroy_cpvm	`Error`	659.22	test_ssvm.py
test_01_migrate_VM_and_root_volume	`Error`	69.16	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.18	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	702.36	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	637.15	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	637.92	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	637.14	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	607.69	test_vm_life_cycle.py
test_01_create_vm_snapshots	`Failure`	604.67	test_vm_snapshots.py
test_02_revert_vm_snapshots	`Failure`	601.60	test_vm_snapshots.py
test_03_delete_vm_snapshots	`Failure`	0.01	test_vm_snapshots.py
test_01_create_volume	`Failure`	607.76	test_volumes.py
test_02_attach_volume	`Failure`	607.63	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	829.13	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	828.06	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	745.13	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	707.02	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	805.23	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	830.15	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Failure`	744.27	test_vpc_router_nics.py
test_02_VPC_default_routes	`Failure`	724.19	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	344.00	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	248.87	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	283.33	test_vpc_vpn.py
test_hostha_enable_ha_when_host_disabled	`Error`	1.43	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	604.00	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	301.55	test_hostha_kvm.py

davidjumani · 2021-03-19T04:32:53Z

@blueorangutan test

blueorangutan · 2021-03-19T04:34:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]

blueorangutan · 2021-03-20T09:10:36Z

[S] Trillian test result (tid-178)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 101388 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4806-t178-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 26 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_lb_rule_src_nat	`Failure`	309.10	test_loadbalance.py
test_02_create_lb_rule_non_nat	`Failure`	35.64	test_loadbalance.py
test_assign_and_removal_lb	`Failure`	35.63	test_loadbalance.py
test_01_verify_libvirt	`Error`	602.82	test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart	`Error`	610.00	test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk	`Error`	606.93	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	`Error`	602.09	test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart	`Error`	612.02	test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again	`Error`	602.05	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestAddConfigtoDeployVM>:setup	`Error`	0.00	test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_nat	`Failure`	606.07	test_network.py
test_02_port_fwd_on_non_src_nat	`Failure`	608.09	test_network.py
ContextSuite context=TestPrivateVlansL2Networks>:setup	`Error`	1231.50	test_network.py
test_reboot_router	`Failure`	359.00	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	`Error`	608.62	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	`Error`	609.07	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	`Error`	612.11	test_network.py
test_isolate_network_password_server	`Failure`	158.60	test_password_server.py
test_02_vpc_privategw_static_routes	`Failure`	759.42	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	755.79	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	865.10	test_privategw_acl.py
test_01_disableHumanReadableLogs	`Error`	602.74	test_human_readable_logs.py
test_02_enableHumanReadableLogs	`Error`	602.72	test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	270.25	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	323.45	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	137.19	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	202.41	test_internal_lb.py
test_01_deploy_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	0.01	test_kubernetes_supported_versions.py
test_router_dhcphosts	`Failure`	157.08	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown	`Error`	167.38	test_router_dhcphosts.py
test_router_dhcp_opts	`Error`	609.28	test_router_dhcphosts.py
test_router_dns_guestipquery	`Failure`	454.49	test_router_dns.py
test_router_dns_guestipquery	`Failure`	455.05	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	659.44	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	721.80	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	209.88	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Failure`	209.71	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	244.59	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Failure`	244.50	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	690.53	test_routers_network_ops.py
test_01_router_internal_basic	`Error`	602.71	test_routers.py
test_02_router_internal_adv	`Error`	602.73	test_routers.py
test_04_restart_network_wo_cleanup	`Error`	604.86	test_routers.py
test_01_service_offering_cpu_limit_use	`Error`	100.47	test_service_offerings.py
test_04_change_offering_small	`Failure`	713.30	test_service_offerings.py
test_01_snapshot_root_disk	`Error`	604.87	test_snapshots.py
test_03_ssvm_internals	`Error`	602.70	test_ssvm.py
test_04_cpvm_internals	`Error`	602.79	test_ssvm.py
test_05_stop_ssvm	`Error`	677.60	test_ssvm.py
test_06_stop_cpvm	`Error`	655.50	test_ssvm.py
test_07_reboot_ssvm	`Error`	717.19	test_ssvm.py
test_08_reboot_cpvm	`Error`	623.98	test_ssvm.py
test_09_destroy_ssvm	`Error`	675.43	test_ssvm.py
test_10_destroy_cpvm	`Error`	656.28	test_ssvm.py
test_01_migrate_VM_and_root_volume	`Error`	65.19	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	49.10	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	702.24	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	637.14	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	637.36	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	637.20	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	607.86	test_vm_life_cycle.py
test_01_create_vm_snapshots	`Failure`	604.48	test_vm_snapshots.py
test_02_revert_vm_snapshots	`Failure`	601.37	test_vm_snapshots.py
test_03_delete_vm_snapshots	`Failure`	0.02	test_vm_snapshots.py
test_01_create_volume	`Failure`	609.87	test_volumes.py
test_02_attach_volume	`Failure`	606.57	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	830.14	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	829.05	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	745.15	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	707.89	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	800.32	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	824.19	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Failure`	723.89	test_vpc_router_nics.py
test_02_VPC_default_routes	`Failure`	723.27	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	346.88	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	250.11	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	288.28	test_vpc_vpn.py
test_hostha_enable_ha_when_host_disabled	`Error`	1.46	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	604.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	300.55	test_hostha_kvm.py

rohityadavcloud · 2021-03-22T06:46:14Z

@davidjumani can you check why we've so many failures? Is it because of the PR or env?
@blueorangutan test

blueorangutan · 2021-03-22T06:47:05Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-22T10:41:19Z

Trillian Build Failed (tid-206)

blueorangutan · 2021-03-22T21:06:46Z

Trillian test result (tid-207)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35660 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4806-t207-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	67.26	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	48.09	test_vm_life_cycle.py

davidjumani · 2021-03-23T03:59:02Z

@rhtyd Was an env issue. The new env is running fine ^^

vpc: dnsmasq is not started if use.external.dns is true

ee58fe0

ustcweizhou added 2 commits March 15, 2021 14:23

Revert "vpc: dnsmasq is not started if use.external.dns is true"

f73cef3

This reverts commit ee58fe0.

apache#4806 vpc: fix zone dns1/dns2 are missing in vpc VR when resta…

361b880

…rt vpc or vpc VR

DaanHoogland added the type:bug label Mar 15, 2021

DaanHoogland added this to the 4.15.1.0 milestone Mar 15, 2021

DaanHoogland approved these changes Mar 15, 2021

View reviewed changes

davidjumani approved these changes Mar 16, 2021

View reviewed changes

rohityadavcloud merged commit 40d93af into apache:4.15 Mar 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vpc: dnsmasq is not started if use.external.dns is true #4806

vpc: dnsmasq is not started if use.external.dns is true #4806

ustcweizhou commented Mar 12, 2021 •

edited by weizhouapache

davidjumani commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 15, 2021 •

edited

davidjumani commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

use.external.dns = false

use.external.dns = true

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

davidjumani commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

davidjumani commented Mar 16, 2021 •

edited

rohityadavcloud commented Mar 17, 2021

blueorangutan commented Mar 17, 2021

blueorangutan commented Mar 18, 2021

davidjumani commented Mar 19, 2021

blueorangutan commented Mar 19, 2021

blueorangutan commented Mar 20, 2021

rohityadavcloud commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

davidjumani commented Mar 23, 2021

vpc: dnsmasq is not started if use.external.dns is true #4806

vpc: dnsmasq is not started if use.external.dns is true #4806

Conversation

ustcweizhou commented Mar 12, 2021 • edited by weizhouapache

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

davidjumani commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 15, 2021 • edited

use.external.dns = false

use.external.dns = true

davidjumani commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

use.external.dns = false

use.external.dns = true

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

weizhouapache commented Mar 15, 2021

blueorangutan commented Mar 15, 2021

davidjumani commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

davidjumani commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

blueorangutan commented Mar 16, 2021

davidjumani commented Mar 16, 2021 • edited

rohityadavcloud commented Mar 17, 2021

blueorangutan commented Mar 17, 2021

blueorangutan commented Mar 18, 2021

davidjumani commented Mar 19, 2021

blueorangutan commented Mar 19, 2021

blueorangutan commented Mar 20, 2021

rohityadavcloud commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

blueorangutan commented Mar 22, 2021

davidjumani commented Mar 23, 2021

ustcweizhou commented Mar 12, 2021 •

edited by weizhouapache

davidjumani commented Mar 15, 2021 •

edited

davidjumani commented Mar 16, 2021 •

edited