ui: Consider overprovisioning when displaying allocated progress #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjumani
changed the title
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S] |
|
UI build: ✔️ |
|
[S] Trillian Build Failed (tid-186) |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 196 |
shwstppr
approved these changes
Mar 22, 2021
|
@rhtyd I compared primary storage capacity with and without changes |
|
Primary storages is the only place where disksizeallocatedgb is used |
|
@rhtyd Tested in the primary storage. |
|
Thanks all I'll merge based on your remarks and testing |
DaanHoogland
pushed a commit
that referenced
this pull request
Mar 23, 2021
* 4.15: ui: Consider overprovisioning factor when displaying allocated progress bar (#4850) ui: Fix the styles action button (#4856) ui: Fill out the search filter form field after performing a filter (#4855) ui: fix add cluster form for vmware (#4841) ui: Fix add primary store during Zone Deployment for PreSetup protocol (#4845) tests: Extend wait time after interrupt (#4815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the UI info card by considering the overprovisioning factor while displaying the disk allocated progress bar
Types of changes
Bug Severity
Screenshots (if appropriate):
Before:
After: