Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Disabled root disk size customization if Service Offering has a fixed size #4933

Merged
merged 1 commit into from Apr 20, 2021
Merged

UI: Disabled root disk size customization if Service Offering has a fixed size #4933

merged 1 commit into from Apr 20, 2021

Conversation

utchoang
Copy link

@utchoang utchoang commented Apr 19, 2021 •
edited

Description

Fixes #4930

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image
image

How Has This Been Tested?

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4933 (SL-JID-101)

wido
wido approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the quick fix!

GabrielBrascher
GabrielBrascher approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works perfectly. Thanks, @utchoang!
LGTM

@GabrielBrascher GabrielBrascher added this to the 4.15.1.0 milestone Apr 19, 2021
@rohityadavcloud rohityadavcloud merged commit 8edd709 into apache:4.15 Apr 20, 2021
@rohityadavcloud rohityadavcloud mentioned this pull request Apr 20, 2021
Closed
@utchoang utchoang deleted the feature/disabled-custom-root-disk-size branch April 22, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wido wido wido approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

Assignees

@utchoang utchoang

Labels
component:UI status:ready-for-merge
Projects
None yet
Milestone
4.15.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@utchoang @blueorangutan @wido @GabrielBrascher @rohityadavcloud