New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add 'created' field to API response #5210
api: Add 'created' field to API response #5210
Conversation
@blueorangutan package |
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 558 |
api/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of pending additions raised by @DaanHoogland regarding API "since 4.16.0.0" and an autogenerated commented line that could be removed (in my opinion).
Despite these small adjustments, code LGTM.
@blueorangutan package |
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 582 |
@blueorangutan test |
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Thanks @davidjumani |
@nvazquez the comments have been addressed. Thanks |
Thanks @Pearl1594, waiting for test results and should be to merge |
Trillian test result (tid-1311)
|
@Pearl1594 @DaanHoogland please kick another round of packaging + test after PR #5218 is merged |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@blueorangutan test |
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1322)
|
Merging based on approvals and test results, failure seems unrelated |
Description
Fixes: #5209
This PR adds 'created' field to the response of listing Networks, VPCs, Projects, NetworkOffering
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?