Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add 'on / off' to status icon and make it case insensitive #5278

Merged
merged 3 commits into from Aug 5, 2021
Merged

ui: Add 'on / off' to status icon and make it case insensitive #5278

merged 3 commits into from Aug 5, 2021

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Aug 5, 2021 •
edited

Description

Fixes #5255

Adds 'On' to the success case of the status icon

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2021-08-05 10-56-39

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@shwstppr
Copy link
Contributor

shwstppr commented Aug 5, 2021

@davidjumani conflicts here. And what about having it in 4.15?

@davidjumani davidjumani changed the base branch from main to 4.15 August 5, 2021 05:45
@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@davidjumani davidjumani marked this pull request as ready for review August 5, 2021 05:45
@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5278 (SL-JID-479)

shwstppr
shwstppr requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani can you please also add 'Off' state

@davidjumani
Copy link
Contributor Author

@davidjumani can you please also add 'Off' state

The default state is takes care of it (grey icon)

@shwstppr
Copy link
Contributor

shwstppr commented Aug 5, 2021

@davidjumani Off is not the default state I think. In code we have 4 states defined here, https://github.com/apache/cloudstack/blob/4.15/api/src/main/java/org/apache/cloudstack/outofbandmanagement/OutOfBandManagement.java#L90-L93

@davidjumani davidjumani changed the title ui: Add 'on' to success status icon ui: Add 'on / off' to success status icon Aug 5, 2021
@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@davidjumani davidjumani changed the title ui: Add 'on / off' to success status icon ui: Add 'on / off' to status icon and make it case insensitive Aug 5, 2021
@shwstppr
Copy link
Contributor

shwstppr commented Aug 5, 2021

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5278 (SL-JID-480)

shwstppr
shwstppr approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with simulator
Screenshot from 2021-08-05 12-40-44

nvazquez
nvazquez approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@nvazquez nvazquez merged commit d8c407d into apache:4.15 Aug 5, 2021
@nvazquez nvazquez mentioned this pull request Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@utchoang utchoang utchoang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Out-of-band Management visual Power state
5 participants
@davidjumani @shwstppr @blueorangutan @nvazquez @utchoang