Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix failure in deletion of templates #5283

Merged
merged 1 commit into from Aug 6, 2021

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #5280, which fixes failure in deletion of templates

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Register a template and attempt deleting the template from a particular zone - It successfully deletes the template

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

looks good @Pearl1594
Is this a regression?

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5283 (SL-JID-482)

@Pearl1594
Copy link
Contributor Author

Yes @DaanHoogland it is a regression - seems to have been caused by #5034. Thanks

@Pearl1594 Pearl1594 requested a review from utchoang August 6, 2021 03:52
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaanHoogland DaanHoogland added this to the 4.16.0.0 milestone Aug 6, 2021
@DaanHoogland DaanHoogland merged commit f9fbd86 into apache:main Aug 6, 2021
@DaanHoogland DaanHoogland deleted the fix-template-delete branch August 6, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete template from zone stopped working
4 participants