Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Fix sending false for isdynamicallyscalable, haenable in EditVM #5299

Merged
merged 1 commit into from Aug 10, 2021
Merged

ui: Fix sending false for isdynamicallyscalable, haenable in EditVM #5299

merged 1 commit into from Aug 10, 2021

Conversation

davidjumani
Copy link
Contributor

Description

Fixes #5271

Prevents sending false for isdynamicallyscalable, haenable when no value is provided

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2021-08-10 12-17-58
Screenshot from 2021-08-10 12-19-15

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@davidjumani davidjumani mentioned this pull request Aug 10, 2021
Closed
@utchoang
Copy link

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5299 (SL-JID-501)

utchoang
utchoang approved these changes Aug 10, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nvazquez
nvazquez approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez added this to the 4.16.0.0 milestone Aug 10, 2021
@nvazquez nvazquez merged commit 3395a65 into apache:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@utchoang utchoang utchoang approved these changes

Assignees
No one assigned
Labels
component:UI type:bug
Projects
None yet
Milestone
4.16.0.0
Development

Successfully merging this pull request may close these issues.

Dynamically Scalable and HA Enabled misbehaving on VMware
5 participants
@davidjumani @utchoang @blueorangutan @shwstppr @nvazquez