Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Honour default.ui.page.size #5394

Merged
merged 3 commits into from Sep 3, 2021
Merged

ui: Honour default.ui.page.size #5394

merged 3 commits into from Sep 3, 2021

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Sep 1, 2021 •
edited

Fixes #5338

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-586)

@davidjumani davidjumani added this to the 4.15.2.0 milestone Sep 1, 2021
@davidjumani davidjumani mentioned this pull request Sep 1, 2021
Closed
shwstppr
shwstppr reviewed Sep 1, 2021
View reviewed changes
engine/schema/src/main/resources/META-INF/db/schema-41500to41510.sql Outdated
@@ -132,3 +132,5 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers

-- Add support for windows2019srvNext_64Guest from VMware 7.0.1.0
INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'VMware', '7.0.1.0', 'windows2019srvNext_64Guest', 276, now(), 0);

UPDATE `cloud`.`configuration` SET `value` = 20, `default_value` = 20 WHERE `name` = 'default.ui.page.size';
Copy link
Contributor

@shwstppr shwstppr Sep 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani won't we have to create a 41510to41520 upgrade path for it to work for 4.15.1 to 4.15.2 upgrade?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If config key exists we shouldn't need it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will make the change

utchoang
utchoang approved these changes Sep 1, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI LGTM!

@rohityadavcloud
Copy link
Member

@davidjumani pl remove changes for 3121, I can't accept too many core UI changes closer to the RC.

@davidjumani
Copy link
Contributor Author

Converting to draft until the sql code is moved to the right path

@davidjumani davidjumani marked this pull request as draft September 1, 2021 11:54
@rohityadavcloud
Copy link
Member

@davidjumani can you only keep changes strictly for #5338 and remove any other changes?

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-593)

@davidjumani davidjumani changed the title ui: Fetch all records && honour default.ui.page.size ui: Honour default.ui.page.size Sep 2, 2021
@rohityadavcloud
Copy link
Member

@davidjumani check latest 4.15, upgrade path is now available.

@davidjumani davidjumani marked this pull request as ready for review September 3, 2021 04:21
@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5394 (SL-JID-598)

@rohityadavcloud
Copy link
Member

Need one more review/test - @davidjumani @shwstppr @nvazquez @sureshanaparti...

@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1124

shwstppr
shwstppr approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test upgrade from 4.15.1.
Config value updated to 20. Config is honored in the UI listviews

@rohityadavcloud rohityadavcloud merged commit 0bc6e05 into apache:4.15 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud left review comments

@shwstppr shwstppr shwstppr approved these changes

@utchoang utchoang utchoang approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.15.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidjumani @blueorangutan @rohityadavcloud @shwstppr @utchoang