Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change logging during upgrade #5474

Merged
merged 2 commits into from Sep 20, 2021
Merged

change logging during upgrade #5474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55bcd4e
reduce ERROR logging on ignored exception
Sep 20, 2021
77ced4c
string concat formatting
DaanHoogland Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 16 additions & 3 deletions engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java
View file
Open in desktop
Expand Up @@ -2388,19 +2388,32 @@ private void migrateDatafromIsoIdInVolumesTable(Connection conn) {
conn.prepareStatement("ALTER TABLE `cloud`.`volumes` CHANGE COLUMN `iso_id1` `iso_id` bigint(20) unsigned COMMENT 'The id of the iso from which the volume was created'");) {
alter_iso_pstmt.executeUpdate();
}catch (SQLException e) {
s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
if (s_logger.isTraceEnabled()) {
s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
}
//implies iso_id1 is not present, so do nothing.
}
}catch (SQLException e) {
s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
if (s_logger.isTraceEnabled()) {
s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
}
//implies iso_id1 is not present, so do nothing.
}
}
}catch (SQLException e) {
s_logger.error("migrateDatafromIsoIdInVolumesTable:Exception:"+e.getMessage(),e);
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
if (s_logger.isTraceEnabled()) {
s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
}
//implies iso_id1 is not present, so do nothing.
}
} catch (SQLException e) {
s_logger.info("migrateDatafromIsoIdInVolumesTable: ignoring Exception: " + e.getMessage());
if (s_logger.isTraceEnabled()) {
s_logger.trace("migrateDatafromIsoIdInVolumesTable: ignored Exception",e);
}
//implies iso_id1 is not present, so do nothing.
}
}
Expand Down